Document ObjectLiteralElementLike (microsoft#26024)

Andy · web-flow · commit 644ceab02f2b · 2018-07-27T17:33:42.000-07:00
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -858,6 +858,7 @@ namespace ts {
         name?: PropertyName;
     }
 
+    /** Unlike ObjectLiteralElement, excludes JSXAttribute and JSXSpreadAttribute. */
     export type ObjectLiteralElementLike
         = PropertyAssignment
         | ShorthandPropertyAssignment
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -6632,18 +6632,7 @@ namespace ts {
     }
 
     export function isObjectLiteralElement(node: Node): node is ObjectLiteralElement {
-        switch (node.kind) {
-            case SyntaxKind.JsxAttribute:
-            case SyntaxKind.JsxSpreadAttribute:
-            case SyntaxKind.PropertyAssignment:
-            case SyntaxKind.ShorthandPropertyAssignment:
-            case SyntaxKind.MethodDeclaration:
-            case SyntaxKind.GetAccessor:
-            case SyntaxKind.SetAccessor:
-                return true;
-            default:
-                return false;
-        }
+        return node.kind === SyntaxKind.JsxAttribute || node.kind === SyntaxKind.JsxSpreadAttribute || isObjectLiteralElementLike(node);
     }
 
     /* @internal */
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -616,6 +616,7 @@ declare namespace ts {
         _objectLiteralBrandBrand: any;
         name?: PropertyName;
     }
+    /** Unlike ObjectLiteralElement, excludes JSXAttribute and JSXSpreadAttribute. */
     type ObjectLiteralElementLike = PropertyAssignment | ShorthandPropertyAssignment | SpreadAssignment | MethodDeclaration | AccessorDeclaration;
     interface PropertyAssignment extends ObjectLiteralElement, JSDocContainer {
         parent: ObjectLiteralExpression;
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -616,6 +616,7 @@ declare namespace ts {
         _objectLiteralBrandBrand: any;
         name?: PropertyName;
     }
+    /** Unlike ObjectLiteralElement, excludes JSXAttribute and JSXSpreadAttribute. */
     type ObjectLiteralElementLike = PropertyAssignment | ShorthandPropertyAssignment | SpreadAssignment | MethodDeclaration | AccessorDeclaration;
     interface PropertyAssignment extends ObjectLiteralElement, JSDocContainer {
         parent: ObjectLiteralExpression;

Original file line number	Diff line number	Diff line change
`@@ -858,6 +858,7 @@ namespace ts {`
`858`	`858`	`name?: PropertyName;`
`859`	`859`	`}`
`860`	`860`
	`861`	`+ /** Unlike ObjectLiteralElement, excludes JSXAttribute and JSXSpreadAttribute. */`
`861`	`862`	`export type ObjectLiteralElementLike`
`862`	`863`	`= PropertyAssignment`
`863`	`864`	`\| ShorthandPropertyAssignment`
Original file line number	Diff line number	Diff line change
`@@ -616,6 +616,7 @@ declare namespace ts {`
`616`	`616`	`_objectLiteralBrandBrand: any;`
`617`	`617`	`name?: PropertyName;`
`618`	`618`	`}`
	`619`	`+ /** Unlike ObjectLiteralElement, excludes JSXAttribute and JSXSpreadAttribute. */`
`619`	`620`	`type ObjectLiteralElementLike = PropertyAssignment \| ShorthandPropertyAssignment \| SpreadAssignment \| MethodDeclaration \| AccessorDeclaration;`
`620`	`621`	`interface PropertyAssignment extends ObjectLiteralElement, JSDocContainer {`
`621`	`622`	`parent: ObjectLiteralExpression;`