Merge pull request microsoft#21505 from armanio123/SetNoEmitTrueJsConfig

Armando Aguirre · web-flow · commit 6435d2651073 · 2018-01-31T11:08:04.000-08:00
Set noEmit = true  on jsconfig.json file
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -1796,7 +1796,7 @@ namespace ts {
 
     function getDefaultCompilerOptions(configFileName?: string) {
         const options: CompilerOptions = getBaseFileName(configFileName) === "jsconfig.json"
-            ? { allowJs: true, maxNodeModuleJsDepth: 2, allowSyntheticDefaultImports: true, skipLibCheck: true }
+            ? { allowJs: true, maxNodeModuleJsDepth: 2, allowSyntheticDefaultImports: true, skipLibCheck: true, noEmit: true }
             : {};
         return options;
     }
diff --git a/src/harness/unittests/convertCompilerOptionsFromJson.ts b/src/harness/unittests/convertCompilerOptionsFromJson.ts
@@ -457,6 +457,7 @@ namespace ts {
                         maxNodeModuleJsDepth: 2,
                         allowSyntheticDefaultImports: true,
                         skipLibCheck: true,
+                        noEmit: true,
                         module: ModuleKind.CommonJS,
                         target: ScriptTarget.ES5,
                         noImplicitAny: false,
@@ -486,6 +487,7 @@ namespace ts {
                         maxNodeModuleJsDepth: 2,
                         allowSyntheticDefaultImports: true,
                         skipLibCheck: true,
+                        noEmit: true,
                         module: ModuleKind.CommonJS,
                         target: ScriptTarget.ES5,
                         noImplicitAny: false,
@@ -510,7 +512,8 @@ namespace ts {
                         allowJs: true,
                         maxNodeModuleJsDepth: 2,
                         allowSyntheticDefaultImports: true,
-                        skipLibCheck: true
+                        skipLibCheck: true,
+                        noEmit: true
                     },
                     errors: [{
                         file: undefined,
@@ -532,7 +535,8 @@ namespace ts {
                         allowJs: true,
                         maxNodeModuleJsDepth: 2,
                         allowSyntheticDefaultImports: true,
-                        skipLibCheck: true
+                        skipLibCheck: true,
+                        noEmit: true
                     },
                     errors: []
                 }
diff --git a/src/harness/unittests/telemetry.ts b/src/harness/unittests/telemetry.ts
@@ -185,6 +185,7 @@ namespace ts.projectSystem {
             allowSyntheticDefaultImports: true,
             maxNodeModuleJsDepth: 2,
             skipLibCheck: true,
+            noEmit: true
         };
 
         it("sends telemetry for typeAcquisition settings", () => {

Original file line number	Diff line number	Diff line change
`@@ -1796,7 +1796,7 @@ namespace ts {`
`1796`	`1796`
`1797`	`1797`	`function getDefaultCompilerOptions(configFileName?: string) {`
`1798`	`1798`	`const options: CompilerOptions = getBaseFileName(configFileName) === "jsconfig.json"`
`1799`		`- ? { allowJs: true, maxNodeModuleJsDepth: 2, allowSyntheticDefaultImports: true, skipLibCheck: true }`
	`1799`	`+ ? { allowJs: true, maxNodeModuleJsDepth: 2, allowSyntheticDefaultImports: true, skipLibCheck: true, noEmit: true }`
`1800`	`1800`	`: {};`
`1801`	`1801`	`return options;`
`1802`	`1802`	`}`