Better erreor messages for properties mis-handled as shorthand property declarations (microsoft#31039)

DanielRosenwasser · web-flow · commit 6427711f9941 · 2019-04-22T16:14:21.000-04:00
Better erreor messages for properties mis-handled as shorthand property declarations
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -2240,7 +2240,7 @@ namespace ts {
             const namespaceMeaning = SymbolFlags.Namespace | (isInJSFile(name) ? meaning & SymbolFlags.Value : 0);
             let symbol: Symbol | undefined;
             if (name.kind === SyntaxKind.Identifier) {
-                const message = meaning === namespaceMeaning ? Diagnostics.Cannot_find_namespace_0 : getCannotFindNameDiagnosticForName(getFirstIdentifier(name).escapedText);
+                const message = meaning === namespaceMeaning ? Diagnostics.Cannot_find_namespace_0 : getCannotFindNameDiagnosticForName(getFirstIdentifier(name));
                 const symbolFromJSPrototype = isInJSFile(name) ? resolveEntityNameFromAssignmentDeclaration(name, meaning) : undefined;
                 symbol = resolveName(location || name, name.escapedText, meaning, ignoreErrors || symbolFromJSPrototype ? undefined : message, name, /*isUse*/ true);
                 if (!symbol) {
@@ -15271,8 +15271,8 @@ namespace ts {
 
         // EXPRESSION TYPE CHECKING
 
-        function getCannotFindNameDiagnosticForName(name: __String): DiagnosticMessage {
-            switch (name) {
+        function getCannotFindNameDiagnosticForName(node: Identifier): DiagnosticMessage {
+            switch (node.escapedText) {
                 case "document":
                 case "console":
                     return Diagnostics.Cannot_find_name_0_Do_you_need_to_change_your_target_library_Try_changing_the_lib_compiler_option_to_include_dom;
@@ -15303,7 +15303,13 @@ namespace ts {
                 case "Iterator":
                 case "AsyncIterator":
                     return Diagnostics.Cannot_find_name_0_Do_you_need_to_change_your_target_library_Try_changing_the_lib_compiler_option_to_es2015_or_later;
-                default: return Diagnostics.Cannot_find_name_0;
+                default:
+                    if (node.parent.kind === SyntaxKind.ShorthandPropertyAssignment) {
+                        return Diagnostics.No_value_exists_in_scope_for_the_shorthand_property_0_Either_declare_one_or_provide_an_initializer;
+                    }
+                    else {
+                        return Diagnostics.Cannot_find_name_0;
+                    }
             }
         }
 
@@ -15315,7 +15321,7 @@ namespace ts {
                         node,
                         node.escapedText,
                         SymbolFlags.Value | SymbolFlags.ExportValue,
-                        getCannotFindNameDiagnosticForName(node.escapedText),
+                        getCannotFindNameDiagnosticForName(node),
                         node,
                         !isWriteOnlyAccess(node),
                         /*excludeGlobals*/ false,
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -4950,5 +4950,9 @@
     "Allow accessing UMD globals from modules.": {
         "category": "Message",
         "code": 95076
+    },
+    "No value exists in scope for the shorthand property '{0}'. Either declare one or provide an initializer." :{
+        "category": "Error",
+        "code": 18004
     }
 }
diff --git a/tests/baselines/reference/checkDestructuringShorthandAssigment.errors.txt b/tests/baselines/reference/checkDestructuringShorthandAssigment.errors.txt
@@ -1,4 +1,4 @@
-tests/cases/compiler/bug25434.js(4,9): error TS2304: Cannot find name 'b'.
+tests/cases/compiler/bug25434.js(4,9): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
 
 
 ==== tests/cases/compiler/bug25434.js (1 errors) ====
@@ -7,5 +7,5 @@ tests/cases/compiler/bug25434.js(4,9): error TS2304: Cannot find name 'b'.
     
     Test(({ b = '5' } = {}));
             ~
-!!! error TS2304: Cannot find name 'b'.
+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
     
diff --git a/tests/baselines/reference/incompleteObjectLiteral1.errors.txt b/tests/baselines/reference/incompleteObjectLiteral1.errors.txt
@@ -1,11 +1,11 @@
-tests/cases/compiler/incompleteObjectLiteral1.ts(1,12): error TS2304: Cannot find name 'aa'.
+tests/cases/compiler/incompleteObjectLiteral1.ts(1,12): error TS18004: No value exists in scope for the shorthand property 'aa'. Either declare one or provide an initializer.
 tests/cases/compiler/incompleteObjectLiteral1.ts(1,14): error TS1005: ',' expected.
 
 
 ==== tests/cases/compiler/incompleteObjectLiteral1.ts (2 errors) ====
     var tt = { aa; }
                ~~
-!!! error TS2304: Cannot find name 'aa'.
+!!! error TS18004: No value exists in scope for the shorthand property 'aa'. Either declare one or provide an initializer.
                  ~
 !!! error TS1005: ',' expected.
     var x = tt;
diff --git a/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNoneExistingIdentifier.errors.txt b/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNoneExistingIdentifier.errors.txt
@@ -1,11 +1,11 @@
-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNoneExistingIdentifier.ts(3,5): error TS2304: Cannot find name 'undefinedVariable'.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNoneExistingIdentifier.ts(3,5): error TS18004: No value exists in scope for the shorthand property 'undefinedVariable'. Either declare one or provide an initializer.
 
 
 ==== tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNoneExistingIdentifier.ts (1 errors) ====
     var x = {
         x, // OK
         undefinedVariable // Error
         ~~~~~~~~~~~~~~~~~
-!!! error TS2304: Cannot find name 'undefinedVariable'.
+!!! error TS18004: No value exists in scope for the shorthand property 'undefinedVariable'. Either declare one or provide an initializer.
     }
     
diff --git a/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.errors.txt b/tests/baselines/reference/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.errors.txt
@@ -7,12 +7,12 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(9,8): error TS1005: ':' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(10,10): error TS1005: ':' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(12,1): error TS1005: ':' expected.
-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,5): error TS2304: Cannot find name 'a'.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,6): error TS1005: ',' expected.
-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,5): error TS2304: Cannot find name 'a'.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,6): error TS1005: ',' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,12): error TS1005: ':' expected.
-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,5): error TS2304: Cannot find name 'a'.
+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,6): error TS1005: ',' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,9): error TS1005: ':' expected.
 tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(20,17): error TS1005: ':' expected.
@@ -53,19 +53,19 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr
     var x = {
         a.b,
         ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
          ~
 !!! error TS1005: ',' expected.
         a["ss"],
         ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
          ~
 !!! error TS1005: ',' expected.
                ~
 !!! error TS1005: ':' expected.
         a[1],
         ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
          ~
 !!! error TS1005: ',' expected.
             ~
diff --git a/tests/baselines/reference/objectLiteralWithSemicolons1.errors.txt b/tests/baselines/reference/objectLiteralWithSemicolons1.errors.txt
@@ -1,19 +1,19 @@
-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,11): error TS2304: Cannot find name 'a'.
+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,11): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,12): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,14): error TS2304: Cannot find name 'b'.
+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,14): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,15): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,17): error TS2304: Cannot find name 'c'.
+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,17): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
 
 
 ==== tests/cases/compiler/objectLiteralWithSemicolons1.ts (5 errors) ====
     var v = { a; b; c }
               ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
                ~
 !!! error TS1005: ',' expected.
                  ~
-!!! error TS2304: Cannot find name 'b'.
+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
                   ~
 !!! error TS1005: ',' expected.
                     ~
-!!! error TS2304: Cannot find name 'c'.
+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
diff --git a/tests/baselines/reference/objectLiteralWithSemicolons2.errors.txt b/tests/baselines/reference/objectLiteralWithSemicolons2.errors.txt
@@ -1,23 +1,23 @@
-tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,3): error TS2304: Cannot find name 'a'.
+tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,4): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,3): error TS2304: Cannot find name 'b'.
+tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,3): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,4): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons2.ts(4,3): error TS2304: Cannot find name 'c'.
+tests/cases/compiler/objectLiteralWithSemicolons2.ts(4,3): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
 
 
 ==== tests/cases/compiler/objectLiteralWithSemicolons2.ts (5 errors) ====
     var v = {
       a;
       ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
        ~
 !!! error TS1005: ',' expected.
       b;
       ~
-!!! error TS2304: Cannot find name 'b'.
+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
        ~
 !!! error TS1005: ',' expected.
       c
       ~
-!!! error TS2304: Cannot find name 'c'.
+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
     }
diff --git a/tests/baselines/reference/objectLiteralWithSemicolons3.errors.txt b/tests/baselines/reference/objectLiteralWithSemicolons3.errors.txt
@@ -1,26 +1,26 @@
-tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,3): error TS2304: Cannot find name 'a'.
+tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,4): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,3): error TS2304: Cannot find name 'b'.
+tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,3): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,4): error TS1005: ',' expected.
-tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,3): error TS2304: Cannot find name 'c'.
+tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,3): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,4): error TS1005: ',' expected.
 
 
 ==== tests/cases/compiler/objectLiteralWithSemicolons3.ts (6 errors) ====
     var v = {
       a;
       ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
        ~
 !!! error TS1005: ',' expected.
       b;
       ~
-!!! error TS2304: Cannot find name 'b'.
+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.
        ~
 !!! error TS1005: ',' expected.
       c;
       ~
-!!! error TS2304: Cannot find name 'c'.
+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.
        ~
 !!! error TS1005: ',' expected.
     }
diff --git a/tests/baselines/reference/objectLiteralWithSemicolons4.errors.txt b/tests/baselines/reference/objectLiteralWithSemicolons4.errors.txt
@@ -1,12 +1,12 @@
-tests/cases/compiler/objectLiteralWithSemicolons4.ts(2,3): error TS2304: Cannot find name 'a'.
+tests/cases/compiler/objectLiteralWithSemicolons4.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/compiler/objectLiteralWithSemicolons4.ts(3,1): error TS1005: ',' expected.
 
 
 ==== tests/cases/compiler/objectLiteralWithSemicolons4.ts (2 errors) ====
     var v = {
       a
       ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
     ;
     ~
 !!! error TS1005: ',' expected.
diff --git a/tests/baselines/reference/parser512097.errors.txt b/tests/baselines/reference/parser512097.errors.txt
@@ -1,11 +1,11 @@
-tests/cases/conformance/parser/ecmascript5/RegressionTests/parser512097.ts(1,12): error TS2304: Cannot find name 'aa'.
+tests/cases/conformance/parser/ecmascript5/RegressionTests/parser512097.ts(1,12): error TS18004: No value exists in scope for the shorthand property 'aa'. Either declare one or provide an initializer.
 tests/cases/conformance/parser/ecmascript5/RegressionTests/parser512097.ts(1,14): error TS1005: ',' expected.
 
 
 ==== tests/cases/conformance/parser/ecmascript5/RegressionTests/parser512097.ts (2 errors) ====
     var tt = { aa; }
                ~~
-!!! error TS2304: Cannot find name 'aa'.
+!!! error TS18004: No value exists in scope for the shorthand property 'aa'. Either declare one or provide an initializer.
                  ~
 !!! error TS1005: ',' expected.
     
diff --git a/tests/baselines/reference/parserErrorRecovery_ObjectLiteral2.errors.txt b/tests/baselines/reference/parserErrorRecovery_ObjectLiteral2.errors.txt
@@ -1,4 +1,4 @@
-tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts(1,11): error TS2304: Cannot find name 'a'.
+tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts(1,11): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
 tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts(2,1): error TS1005: ',' expected.
 tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts(2,7): error TS1005: ':' expected.
 tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts(2,8): error TS1005: '}' expected.
@@ -7,7 +7,7 @@ tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserEr
 ==== tests/cases/conformance/parser/ecmascript5/ErrorRecovery/ObjectLiterals/parserErrorRecovery_ObjectLiteral2.ts (4 errors) ====
     var v = { a
               ~
-!!! error TS2304: Cannot find name 'a'.
+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.
     return;
     ~~~~~~
 !!! error TS1005: ',' expected.
diff --git a/tests/baselines/reference/shorthandPropertyAssignmentsInDestructuring.errors.txt b/tests/baselines/reference/shorthandPropertyAssignmentsInDestructuring.errors.txt
@@ -13,7 +13,7 @@ tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(85,19): erro
   Types of property 'x' are incompatible.
     Type 'number' is not assignable to type 'string'.
 tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(85,26): error TS2322: Type 'number' is not assignable to type 'string'.
-tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(111,12): error TS2304: Cannot find name 's'.
+tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(111,12): error TS18004: No value exists in scope for the shorthand property 's'. Either declare one or provide an initializer.
 tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(111,14): error TS1312: '=' can only be used in an object literal property inside a destructuring assignment.
 
 
@@ -160,7 +160,7 @@ tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring.ts(111,14): err
     (function() {
     	let a = { s = 5 };
     	          ~
-!!! error TS2304: Cannot find name 's'.
+!!! error TS18004: No value exists in scope for the shorthand property 's'. Either declare one or provide an initializer.
     	            ~
 !!! error TS1312: '=' can only be used in an object literal property inside a destructuring assignment.
     });
diff --git a/tests/baselines/reference/shorthandPropertyAssignmentsInDestructuring_ES6.errors.txt b/tests/baselines/reference/shorthandPropertyAssignmentsInDestructuring_ES6.errors.txt
@@ -13,7 +13,7 @@ tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(85,19):
   Types of property 'x' are incompatible.
     Type 'number' is not assignable to type 'string'.
 tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(85,26): error TS2322: Type 'number' is not assignable to type 'string'.
-tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(111,12): error TS2304: Cannot find name 's'.
+tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(111,12): error TS18004: No value exists in scope for the shorthand property 's'. Either declare one or provide an initializer.
 tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(111,14): error TS1312: '=' can only be used in an object literal property inside a destructuring assignment.
 
 
@@ -160,7 +160,7 @@ tests/cases/compiler/shorthandPropertyAssignmentsInDestructuring_ES6.ts(111,14):
     (function() {
     	let a = { s = 5 };
     	          ~
-!!! error TS2304: Cannot find name 's'.
+!!! error TS18004: No value exists in scope for the shorthand property 's'. Either declare one or provide an initializer.
     	            ~
 !!! error TS1312: '=' can only be used in an object literal property inside a destructuring assignment.
     });
diff --git a/tests/baselines/reference/shorthandPropertyUndefined.errors.txt b/tests/baselines/reference/shorthandPropertyUndefined.errors.txt
diff --git a/tests/baselines/reference/shorthandPropertyUndefined.js b/tests/baselines/reference/shorthandPropertyUndefined.js
diff --git a/tests/baselines/reference/shorthandPropertyUndefined.symbols b/tests/baselines/reference/shorthandPropertyUndefined.symbols
diff --git a/tests/baselines/reference/shorthandPropertyUndefined.types b/tests/baselines/reference/shorthandPropertyUndefined.types
diff --git a/tests/cases/compiler/shorthandPropertyUndefined.ts b/tests/cases/compiler/shorthandPropertyUndefined.ts

Original file line number	Diff line number	Diff line change
`@@ -4950,5 +4950,9 @@`
`4950`	`4950`	`"Allow accessing UMD globals from modules.": {`
`4951`	`4951`	`"category": "Message",`
`4952`	`4952`	`"code": 95076`
	`4953`	`+ },`
	`4954`	`+ "No value exists in scope for the shorthand property '{0}'. Either declare one or provide an initializer." :{`
	`4955`	`+ "category": "Error",`
	`4956`	`+ "code": 18004`
`4953`	`4957`	`}`
`4954`	`4958`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-tests/cases/compiler/bug25434.js(4,9): error TS2304: Cannot find name 'b'.`
	`1`	`+tests/cases/compiler/bug25434.js(4,9): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`2`	`2`
`3`	`3`
`4`	`4`	`==== tests/cases/compiler/bug25434.js (1 errors) ====`
`@@ -7,5 +7,5 @@ tests/cases/compiler/bug25434.js(4,9): error TS2304: Cannot find name 'b'.`
`7`	`7`
`8`	`8`	`Test(({ b = '5' } = {}));`
`9`	`9`	`~`
`10`		`-!!! error TS2304: Cannot find name 'b'.`
	`10`	`+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`11`	`11`
Original file line number	Diff line number	Diff line change
`@@ -7,12 +7,12 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr`
`7`	`7`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(9,8): error TS1005: ':' expected.`
`8`	`8`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(10,10): error TS1005: ':' expected.`
`9`	`9`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(12,1): error TS1005: ':' expected.`
`10`		`-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,5): error TS2304: Cannot find name 'a'.`
	`10`	`+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`11`	`11`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(15,6): error TS1005: ',' expected.`
`12`		`-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,5): error TS2304: Cannot find name 'a'.`
	`12`	`+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`13`	`13`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,6): error TS1005: ',' expected.`
`14`	`14`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(16,12): error TS1005: ':' expected.`
`15`		`-tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,5): error TS2304: Cannot find name 'a'.`
	`15`	`+tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,5): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`16`	`16`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,6): error TS1005: ',' expected.`
`17`	`17`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(17,9): error TS1005: ':' expected.`
`18`	`18`	`tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPropertiesErrorFromNotUsingIdentifier.ts(20,17): error TS1005: ':' expected.`
`@@ -53,19 +53,19 @@ tests/cases/conformance/es6/shorthandPropertyAssignment/objectLiteralShorthandPr`
`53`	`53`	`var x = {`
`54`	`54`	`a.b,`
`55`	`55`	`~`
`56`		`-!!! error TS2304: Cannot find name 'a'.`
	`56`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`57`	`57`	`~`
`58`	`58`	`!!! error TS1005: ',' expected.`
`59`	`59`	`a["ss"],`
`60`	`60`	`~`
`61`		`-!!! error TS2304: Cannot find name 'a'.`
	`61`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`62`	`62`	`~`
`63`	`63`	`!!! error TS1005: ',' expected.`
`64`	`64`	`~`
`65`	`65`	`!!! error TS1005: ':' expected.`
`66`	`66`	`a[1],`
`67`	`67`	`~`
`68`		`-!!! error TS2304: Cannot find name 'a'.`
	`68`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`69`	`69`	`~`
`70`	`70`	`!!! error TS1005: ',' expected.`
`71`	`71`	`~`
Original file line number	Diff line number	Diff line change
`@@ -1,19 +1,19 @@`
`1`		`-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,11): error TS2304: Cannot find name 'a'.`
	`1`	`+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,11): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`2`	`2`	`tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,12): error TS1005: ',' expected.`
`3`		`-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,14): error TS2304: Cannot find name 'b'.`
	`3`	`+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,14): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`4`	`4`	`tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,15): error TS1005: ',' expected.`
`5`		`-tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,17): error TS2304: Cannot find name 'c'.`
	`5`	`+tests/cases/compiler/objectLiteralWithSemicolons1.ts(1,17): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
`6`	`6`
`7`	`7`
`8`	`8`	`==== tests/cases/compiler/objectLiteralWithSemicolons1.ts (5 errors) ====`
`9`	`9`	`var v = { a; b; c }`
`10`	`10`	`~`
`11`		`-!!! error TS2304: Cannot find name 'a'.`
	`11`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`12`	`12`	`~`
`13`	`13`	`!!! error TS1005: ',' expected.`
`14`	`14`	`~`
`15`		`-!!! error TS2304: Cannot find name 'b'.`
	`15`	`+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`16`	`16`	`~`
`17`	`17`	`!!! error TS1005: ',' expected.`
`18`	`18`	`~`
`19`		`-!!! error TS2304: Cannot find name 'c'.`
	`19`	`+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
Original file line number	Diff line number	Diff line change
`@@ -1,23 +1,23 @@`
`1`		`-tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,3): error TS2304: Cannot find name 'a'.`
	`1`	`+tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`2`	`2`	`tests/cases/compiler/objectLiteralWithSemicolons2.ts(2,4): error TS1005: ',' expected.`
`3`		`-tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,3): error TS2304: Cannot find name 'b'.`
	`3`	`+tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,3): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`4`	`4`	`tests/cases/compiler/objectLiteralWithSemicolons2.ts(3,4): error TS1005: ',' expected.`
`5`		`-tests/cases/compiler/objectLiteralWithSemicolons2.ts(4,3): error TS2304: Cannot find name 'c'.`
	`5`	`+tests/cases/compiler/objectLiteralWithSemicolons2.ts(4,3): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
`6`	`6`
`7`	`7`
`8`	`8`	`==== tests/cases/compiler/objectLiteralWithSemicolons2.ts (5 errors) ====`
`9`	`9`	`var v = {`
`10`	`10`	`a;`
`11`	`11`	`~`
`12`		`-!!! error TS2304: Cannot find name 'a'.`
	`12`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`13`	`13`	`~`
`14`	`14`	`!!! error TS1005: ',' expected.`
`15`	`15`	`b;`
`16`	`16`	`~`
`17`		`-!!! error TS2304: Cannot find name 'b'.`
	`17`	`+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`18`	`18`	`~`
`19`	`19`	`!!! error TS1005: ',' expected.`
`20`	`20`	`c`
`21`	`21`	`~`
`22`		`-!!! error TS2304: Cannot find name 'c'.`
	`22`	`+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,26 +1,26 @@`
`1`		`-tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,3): error TS2304: Cannot find name 'a'.`
	`1`	`+tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`2`	`2`	`tests/cases/compiler/objectLiteralWithSemicolons3.ts(2,4): error TS1005: ',' expected.`
`3`		`-tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,3): error TS2304: Cannot find name 'b'.`
	`3`	`+tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,3): error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`4`	`4`	`tests/cases/compiler/objectLiteralWithSemicolons3.ts(3,4): error TS1005: ',' expected.`
`5`		`-tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,3): error TS2304: Cannot find name 'c'.`
	`5`	`+tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,3): error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
`6`	`6`	`tests/cases/compiler/objectLiteralWithSemicolons3.ts(4,4): error TS1005: ',' expected.`
`7`	`7`
`8`	`8`
`9`	`9`	`==== tests/cases/compiler/objectLiteralWithSemicolons3.ts (6 errors) ====`
`10`	`10`	`var v = {`
`11`	`11`	`a;`
`12`	`12`	`~`
`13`		`-!!! error TS2304: Cannot find name 'a'.`
	`13`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`14`	`14`	`~`
`15`	`15`	`!!! error TS1005: ',' expected.`
`16`	`16`	`b;`
`17`	`17`	`~`
`18`		`-!!! error TS2304: Cannot find name 'b'.`
	`18`	`+!!! error TS18004: No value exists in scope for the shorthand property 'b'. Either declare one or provide an initializer.`
`19`	`19`	`~`
`20`	`20`	`!!! error TS1005: ',' expected.`
`21`	`21`	`c;`
`22`	`22`	`~`
`23`		`-!!! error TS2304: Cannot find name 'c'.`
	`23`	`+!!! error TS18004: No value exists in scope for the shorthand property 'c'. Either declare one or provide an initializer.`
`24`	`24`	`~`
`25`	`25`	`!!! error TS1005: ',' expected.`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`		`-tests/cases/compiler/objectLiteralWithSemicolons4.ts(2,3): error TS2304: Cannot find name 'a'.`
	`1`	`+tests/cases/compiler/objectLiteralWithSemicolons4.ts(2,3): error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`2`	`2`	`tests/cases/compiler/objectLiteralWithSemicolons4.ts(3,1): error TS1005: ',' expected.`
`3`	`3`
`4`	`4`
`5`	`5`	`==== tests/cases/compiler/objectLiteralWithSemicolons4.ts (2 errors) ====`
`6`	`6`	`var v = {`
`7`	`7`	`a`
`8`	`8`	`~`
`9`		`-!!! error TS2304: Cannot find name 'a'.`
	`9`	`+!!! error TS18004: No value exists in scope for the shorthand property 'a'. Either declare one or provide an initializer.`
`10`	`10`	`;`
`11`	`11`	`~`
`12`	`12`	`!!! error TS1005: ',' expected.`