Don't treat class name as a completion list blocker if the position comes after it (microsoft#20762)

Andy · web-flow · commit 60bd2624370f · 2017-12-18T12:41:05.000-08:00
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -1760,7 +1760,10 @@ namespace ts.Completions {
                     return true;
             }
 
-            return isDeclarationName(contextToken) && !isJsxAttribute(contextToken.parent);
+            return isDeclarationName(contextToken)
+                && !isJsxAttribute(contextToken.parent)
+                // Don't block completions if we're in `class C /**/`, because we're *past* the end of the identifier and might want to complete `extends`.
+                && !(isClassLike(contextToken.parent) && position > previousToken.end);
         }
 
         function isFunctionLikeButNotConstructor(kind: SyntaxKind) {
diff --git a/tests/cases/fourslash/completionsKeywordsExtends.ts b/tests/cases/fourslash/completionsKeywordsExtends.ts
@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts" />
+
+////class C/*a*/ /*b*/ { }
+
+// Tests that `isCompletionListBlocker` is true *at* the class name, but false *after* it.
+
+goTo.marker("a");
+verify.completionListIsEmpty();
+
+goTo.marker("b");
+verify.completionListContains("extends");

Original file line number	Diff line number	Diff line change
`@@ -1760,7 +1760,10 @@ namespace ts.Completions {`
`1760`	`1760`	`return true;`
`1761`	`1761`	`}`
`1762`	`1762`
`1763`		`- return isDeclarationName(contextToken) && !isJsxAttribute(contextToken.parent);`
	`1763`	`+ return isDeclarationName(contextToken)`
	`1764`	`+ && !isJsxAttribute(contextToken.parent)`
	`1765`	+ // Don't block completions if we're in `class C /*/`, because we're past* the end of the identifier and might want to complete `extends`.
	`1766`	`+ && !(isClassLike(contextToken.parent) && position > previousToken.end);`
`1764`	`1767`	`}`
`1765`	`1768`
`1766`	`1769`	`function isFunctionLikeButNotConstructor(kind: SyntaxKind) {`