Remove error with noImplicitAny

Kanchalai Tanglertsampan · Kanchalai Tanglertsampan · commit 6080c3efd686 · 2017-03-28T12:38:41.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -284,7 +284,6 @@ namespace ts {
         let deferredGlobalAsyncIterableIteratorType: GenericType;
         let deferredGlobalTemplateStringsArrayType: ObjectType;
         let deferredJsxElementClassType: Type;
-        let deferredGlobalPromiseAnyType: Type;
 
         let deferredNodes: Node[];
         let deferredUnusedIdentifierNodes: Node[];
@@ -3456,11 +3455,6 @@ namespace ts {
             // Use the type of the initializer expression if one is present
             if (declaration.initializer) {
                 const type = checkDeclarationInitializer(declaration);
-
-                if (isImportCall(declaration.initializer)) {
-                    if (noImplicitAny && type === getGlobalPromiseAnyType()) {
-                        error(declaration, Diagnostics.Cannot_resolve_dynamic_import_implicitly_has_a_Promise_any_type);                    }
-                }
                 return addOptionality(type, /*optional*/ declaration.questionToken && includeOptionality);
             }
 
@@ -6089,10 +6083,6 @@ namespace ts {
             return deferredGlobalPromiseType || (deferredGlobalPromiseType = getGlobalType("Promise", /*arity*/ 1, reportErrors)) || emptyGenericType;
         }
 
-        function getGlobalPromiseAnyType() {
-            return deferredGlobalPromiseAnyType || (deferredGlobalPromiseAnyType = createPromiseType(anyType));
-        }
-
         function getGlobalPromiseConstructorSymbol(reportErrors: boolean): Symbol | undefined {
             return deferredGlobalPromiseConstructorSymbol || (deferredGlobalPromiseConstructorSymbol = getGlobalValueSymbol("Promise", reportErrors));
         }
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -1,4 +1,4 @@
-{
+﻿{
     "Unterminated string literal.": {
         "category": "Error",
         "code": 1002
@@ -3174,14 +3174,11 @@
         "category": "Error",
         "code": 7034
     },
-    "Cannot resolve dynamic import, implicitly has a 'Promise<any>' type.": {
-      "category": "Error",
-      "code": 7035
-    },
     "Dynamic import's specifier must be of type 'string', but here has type '{0}'.": {
-      "category": "Error",
-      "code": 7036
+        "category": "Error",
+        "code": 7035
     },
+
     "You cannot rename this element.": {
         "category": "Error",
         "code": 8000
diff --git a/tests/cases/conformance/es2018/dynamicImport/importCallExpressionNoImplicitAnyError.ts b/tests/cases/conformance/es2018/dynamicImport/importCallExpressionNoImplicitAnyError.ts
diff --git a/tests/cases/conformance/es2018/dynamicImport/importCallExpressionReturnPromiseOfAny.ts b/tests/cases/conformance/es2018/dynamicImport/importCallExpressionReturnPromiseOfAny.ts
@@ -7,12 +7,15 @@ export class C {}
 // @filename: 1.ts
 import * as defaultModule from "./defaultPath";
 declare function getSpecifier(): string;
+declare function ValidSomeCondition(): boolean;
 declare var whatToLoad: boolean;
 declare const directory: string;
 declare const moduleFile: number;
 
 import(`${directory}\${moduleFile}`);
 import(getSpecifier());
+
+var p1 = import(ValidSomeCondition() ? "./0" : "externalModule");
 var p1: Promise<any> = import(getSpecifier());
 var p11: Promise<typeof defaultModule> = import(getSpecifier());
 const p2 = import(whatToLoad ? getSpecifier() : "defaulPath") as Promise<typeof defaultModule>;
