Expand span of @typedef with properties to include the @typedef tag (microsoft#25950)

Andy · web-flow · commit 5e94cf626bed · 2018-07-26T08:56:24.000-07:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -6835,7 +6835,7 @@ namespace ts {
                         let child: JSDocTypeTag | JSDocPropertyTag | false;
                         let jsdocTypeLiteral: JSDocTypeLiteral | undefined;
                         let childTypeTag: JSDocTypeTag | undefined;
-                        const start = scanner.getStartPos();
+                        const start = atToken.pos;
                         while (child = tryParse(() => parseChildPropertyTag())) {
                             if (!jsdocTypeLiteral) {
                                 jsdocTypeLiteral = <JSDocTypeLiteral>createNode(SyntaxKind.JSDocTypeLiteral, start);
diff --git a/tests/baselines/reference/JSDocParsing/DocComments.parsesCorrectly.typedefTagWithChildrenTags.json b/tests/baselines/reference/JSDocParsing/DocComments.parsesCorrectly.typedefTagWithChildrenTags.json
@@ -32,7 +32,7 @@
             },
             "typeExpression": {
                 "kind": "JSDocTypeLiteral",
-                "pos": 28,
+                "pos": 8,
                 "end": 100,
                 "jsDocPropertyTags": [
                     {
diff --git a/tests/cases/fourslash/goToTypeDefinition_typedef.ts b/tests/cases/fourslash/goToTypeDefinition_typedef.ts
@@ -0,0 +1,14 @@
+/// <reference path='fourslash.ts' />
+
+// @allowJs: true
+
+// @Filename: /a.js
+/////**
+//// * /*def*/@typedef {object} I
+//// * @property {number} x
+//// */
+////
+/////** @type {I} */
+////const /*ref*/i = { x: 0 };
+
+verify.goToType("ref", "def");

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`},`
`33`	`33`	`"typeExpression": {`
`34`	`34`	`"kind": "JSDocTypeLiteral",`
`35`		`- "pos": 28,`
	`35`	`+ "pos": 8,`
`36`	`36`	`"end": 100,`
`37`	`37`	`"jsDocPropertyTags": [`
`38`	`38`	`{`