Provide an error when using 'import.meta' without setting 'esnext'.

DanielRosenwasser · DanielRosenwasser · commit 56f4b2eea435 · 2018-04-10T16:12:00.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -18702,10 +18702,7 @@ namespace ts {
             }
 
             if (node.keywordToken === SyntaxKind.ImportKeyword) {
-                const file = getSourceFileOfNode(node);
-                Debug.assert(!!(file.flags & NodeFlags.PossiblyContainsImportMeta), "Containing file is missing import meta node flag.");
-                Debug.assert(!!file.externalModuleIndicator, "Containing file should be a module.");
-                return node.name.escapedText === "meta" ? getGlobalImportMetaType() : unknownType;
+                return checkImportMetaProperty(node);
             }
         }
 
@@ -18725,6 +18722,16 @@ namespace ts {
             }
         }
 
+        function checkImportMetaProperty(node: MetaProperty) {
+            if (languageVersion < ScriptTarget.ESNext && modulekind < ModuleKind.ESNext) {
+                error(node, Diagnostics.The_import_meta_meta_property_is_only_allowed_using_ESNext_for_the_target_and_module_compiler_options);
+            }
+            const file = getSourceFileOfNode(node);
+            Debug.assert(!!(file.flags & NodeFlags.PossiblyContainsImportMeta), "Containing file is missing import meta node flag.");
+            Debug.assert(!!file.externalModuleIndicator, "Containing file should be a module.");
+            return node.name.escapedText === "meta" ? getGlobalImportMetaType() : unknownType;
+        }
+
         function getTypeOfParameter(symbol: Symbol) {
             const type = getTypeOfSymbol(symbol);
             if (strictNullChecks) {
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -967,6 +967,10 @@
         "category": "Error",
         "code": 1342
     },
+    "The 'import.meta' meta-property is only allowed using 'ESNext' for the 'target' and 'module' compiler options.": {
+        "category": "Error",
+        "code": 1343
+    },
 
     "Duplicate identifier '{0}'.": {
         "category": "Error",

Original file line number	Diff line number	Diff line change
`@@ -18702,10 +18702,7 @@ namespace ts {`
`18702`	`18702`	`}`
`18703`	`18703`
`18704`	`18704`	`if (node.keywordToken === SyntaxKind.ImportKeyword) {`
`18705`		`- const file = getSourceFileOfNode(node);`
`18706`		`- Debug.assert(!!(file.flags & NodeFlags.PossiblyContainsImportMeta), "Containing file is missing import meta node flag.");`
`18707`		`- Debug.assert(!!file.externalModuleIndicator, "Containing file should be a module.");`
`18708`		`- return node.name.escapedText === "meta" ? getGlobalImportMetaType() : unknownType;`
	`18705`	`+ return checkImportMetaProperty(node);`
`18709`	`18706`	`}`
`18710`	`18707`	`}`
`18711`	`18708`
`@@ -18725,6 +18722,16 @@ namespace ts {`
`18725`	`18722`	`}`
`18726`	`18723`	`}`
`18727`	`18724`
	`18725`	`+ function checkImportMetaProperty(node: MetaProperty) {`
	`18726`	`+ if (languageVersion < ScriptTarget.ESNext && modulekind < ModuleKind.ESNext) {`
	`18727`	`+ error(node, Diagnostics.The_import_meta_meta_property_is_only_allowed_using_ESNext_for_the_target_and_module_compiler_options);`
	`18728`	`+ }`
	`18729`	`+ const file = getSourceFileOfNode(node);`
	`18730`	`+ Debug.assert(!!(file.flags & NodeFlags.PossiblyContainsImportMeta), "Containing file is missing import meta node flag.");`
	`18731`	`+ Debug.assert(!!file.externalModuleIndicator, "Containing file should be a module.");`
	`18732`	`+ return node.name.escapedText === "meta" ? getGlobalImportMetaType() : unknownType;`
	`18733`	`+ }`
	`18734`	`+`
`18728`	`18735`	`function getTypeOfParameter(symbol: Symbol) {`
`18729`	`18736`	`const type = getTypeOfSymbol(symbol);`
`18730`	`18737`	`if (strictNullChecks) {`