Merge pull request microsoft#22963 from Microsoft/incrementalEditWithJsDocNode

sheetalkamat · web-flow · commit 5472ca9ed8e2 · 2018-03-28T15:42:18.000-07:00
Correct the incremental parsing when there is jsDoc node
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -6965,7 +6965,7 @@ namespace ts {
                 forEachChild(node, visitNode, visitArray);
                 if (hasJSDocNodes(node)) {
                     for (const jsDocComment of node.jsDoc) {
-                        forEachChild(jsDocComment, visitNode, visitArray);
+                        visitNode(<IncrementalNode><Node>jsDocComment);
                     }
                 }
                 checkNodePositions(node, aggressiveChecks);
@@ -7071,10 +7071,16 @@ namespace ts {
         function checkNodePositions(node: Node, aggressiveChecks: boolean) {
             if (aggressiveChecks) {
                 let pos = node.pos;
-                forEachChild(node, child => {
+                const visitNode = (child: Node) => {
                     Debug.assert(child.pos >= pos);
                     pos = child.end;
-                });
+                };
+                if (hasJSDocNodes(node)) {
+                    for (const jsDocComment of node.jsDoc) {
+                        visitNode(jsDocComment);
+                    }
+                }
+                forEachChild(node, visitNode);
                 Debug.assert(pos <= node.end);
             }
         }
@@ -7112,7 +7118,11 @@ namespace ts {
                     // Adjust the pos or end (or both) of the intersecting element accordingly.
                     adjustIntersectingElement(child, changeStart, changeRangeOldEnd, changeRangeNewEnd, delta);
                     forEachChild(child, visitNode, visitArray);
-
+                    if (hasJSDocNodes(child)) {
+                        for (const jsDocComment of child.jsDoc) {
+                            visitNode(<IncrementalNode><Node>jsDocComment);
+                        }
+                    }
                     checkNodePositions(child, aggressiveChecks);
                     return;
                 }
diff --git a/tests/cases/fourslash/incrementalParsingWithJsDoc.ts b/tests/cases/fourslash/incrementalParsingWithJsDoc.ts
@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts"/>
+
+////import a from 'a/aaaaaaa/aaaaaaa/aaaaaa/aaaaaaa';
+/////**/import b from 'b';
+////import c from 'c';
+////
+////[|/** @internal */|]
+////export class LanguageIdentifier[| { }|]
+
+// Force a syntax tree ot be created.
+verify.outliningSpansInCurrentFile(test.ranges());
+goTo.marker("");
+edit.backspace(test.marker("").position);
+verify.outliningSpansInCurrentFile(test.ranges());
+
