Skip to content

Commit 5217574

Browse files
committed
split lint task to list-scripts, lint-compiler. add list-scripts, lint-compiler to postTest
1 parent 034ba9f commit 5217574

2 files changed

Lines changed: 22 additions & 16 deletions

File tree

Gulpfile.js

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -318,18 +318,18 @@ task("clean-tests").description = "Cleans the outputs for the test infrastructur
318318

319319
const watchTests = () => watchProject("src/testRunner", cmdLineOptions);
320320

321-
const buildRules = () => buildProject("scripts/eslint");
322-
task("build-rules", buildRules);
323-
task("build-rules").description = "Compiles eslint rules to js";
321+
const buildEslintRules = () => buildProject("scripts/eslint");
322+
task("build-eslint-rules", buildEslintRules);
323+
task("build-eslint-rules").description = "Compiles eslint rules to js";
324324

325-
const cleanRules = () => cleanProject("scripts/eslint");
326-
cleanTasks.push(cleanRules);
327-
task("clean-rules", cleanRules);
328-
task("clean-rules").description = "Cleans the outputs for the eslint rules";
325+
const cleanEslintRules = () => cleanProject("scripts/eslint");
326+
cleanTasks.push(cleanEslintRules);
327+
task("clean-eslint-rules", cleanEslintRules);
328+
task("clean-eslint-rules").description = "Cleans the outputs for the eslint rules";
329329

330-
const runRulesTests = () => runConsoleTests("built/eslint/tests", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
331-
task("run-rules-tests", series(buildRules, runRulesTests));
332-
task("run-rules-tests").description = "Runs the eslint rule tests";
330+
const runEslintRulesTests = () => runConsoleTests("built/eslint/tests", "mocha-fivemat-progress-reporter", /*runInParallel*/ false, /*watchMode*/ false);
331+
task("run-eslint-rules-tests", series(buildEslintRules, runEslintRulesTests));
332+
task("run-eslint-rules-tests").description = "Runs the eslint rule tests";
333333

334334
const lintFoldStart = async () => { if (fold.isTravis()) console.log(fold.start("lint")); };
335335
const lintFoldEnd = async () => { if (fold.isTravis()) console.log(fold.end("lint")); };
@@ -350,15 +350,20 @@ const eslint = (path) => async () => {
350350
return exec(process.execPath, args);
351351
}
352352

353-
const lintScripts = series([buildRules, eslint("scripts/**/*.ts")]);
353+
const lintScripts = eslint("scripts/**/*.ts");
354354
lintScripts.displayName = "lint-scripts";
355-
task("lint-scripts", lintScripts);
355+
task("lint-scripts", series([buildEslintRules, lintFoldStart, lintScripts, lintFoldEnd]));
356356
task("lint-scripts").description = "Runs eslint on the scripts sources.";
357357

358-
const lint = series([buildRules, lintFoldStart, eslint("src/**/*.ts"), lintFoldEnd]);
358+
const lintCompiler = eslint("src/**/*.ts");
359+
lintCompiler.displayName = "lint-compiler";
360+
task("lint-compiler", series([buildEslintRules, lintFoldStart, lintCompiler, lintFoldEnd]));
361+
task("lint-compiler").description = "Runs eslint on the compiler sources.";
362+
363+
const lint = series([buildEslintRules, lintFoldStart, lintScripts, lintCompiler, lintFoldEnd]);
359364
lint.displayName = "lint";
360-
task("lint", lint);
361-
task("lint").description = "Runs eslint on the compiler sources.";
365+
task("lint", series([buildEslintRules, lintFoldStart, lint, lintFoldEnd]));
366+
task("lint").description = "Runs eslint on the compiler and scripts sources.";
362367

363368
const buildCancellationToken = () => buildProject("src/cancellationToken");
364369
const cleanCancellationToken = () => cleanProject("src/cancellationToken");

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
"scripts": {
105105
"pretest": "gulp tests",
106106
"test": "gulp runtests-parallel --light=false",
107-
"test:eslint-rules": "gulp run-rules-tests",
107+
"test:eslint-rules": "gulp run-eslint-rules-tests",
108108
"build": "npm run build:compiler && npm run build:tests",
109109
"build:compiler": "gulp local",
110110
"build:tests": "gulp tests",
@@ -113,6 +113,7 @@
113113
"gulp": "gulp",
114114
"jake": "gulp",
115115
"lint": "gulp lint",
116+
"lint:compiler": "gulp lint-compiler",
116117
"lint:scripts": "gulp lint-scripts",
117118
"setup-hooks": "node scripts/link-hooks.js",
118119
"update-costly-tests": "node scripts/costly-tests.js"

0 commit comments

Comments
 (0)