Add depth limit to recursive type reference id generation

sandersn · sandersn · commit 520d7fff49d9 · 2017-09-01T14:19:12.000-07:00
4 is the limit.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -9790,7 +9790,7 @@ namespace ts {
          * getTypeReferenceId(A<T, number, U>) returns "111=0-12=1"
          *   where A.id=111 and number.id=12
          */
-        function getTypeReferenceId(type: TypeReference, typeParameters: Type[]) {
+        function getTypeReferenceId(type: TypeReference, typeParameters: Type[], depth = 0) {
             let result = "" + type.target.id;
             for (const t of type.typeArguments) {
                 if (isUnconstrainedTypeParameter(t)) {
@@ -9801,8 +9801,8 @@ namespace ts {
                     }
                     result += "=" + index;
                 }
-                else if (isTypeReferenceWithGenericArguments(t)) {
-                    result += "<" + getTypeReferenceId(t, typeParameters) + ">";
+                else if (depth < 4 && isTypeReferenceWithGenericArguments(t)) {
+                    result += "<" + getTypeReferenceId(t, typeParameters, depth + 1) + ">";
                 }
                 else {
                     result += "-" + t.id;

Original file line number	Diff line number	Diff line change
`@@ -9790,7 +9790,7 @@ namespace ts {`
`9790`	`9790`	`* getTypeReferenceId(A<T, number, U>) returns "111=0-12=1"`
`9791`	`9791`	`* where A.id=111 and number.id=12`
`9792`	`9792`	`*/`
`9793`		`- function getTypeReferenceId(type: TypeReference, typeParameters: Type[]) {`
	`9793`	`+ function getTypeReferenceId(type: TypeReference, typeParameters: Type[], depth = 0) {`
`9794`	`9794`	`let result = "" + type.target.id;`
`9795`	`9795`	`for (const t of type.typeArguments) {`
`9796`	`9796`	`if (isUnconstrainedTypeParameter(t)) {`
`@@ -9801,8 +9801,8 @@ namespace ts {`
`9801`	`9801`	`}`
`9802`	`9802`	`result += "=" + index;`
`9803`	`9803`	`}`
`9804`		`- else if (isTypeReferenceWithGenericArguments(t)) {`
`9805`		`- result += "<" + getTypeReferenceId(t, typeParameters) + ">";`
	`9804`	`+ else if (depth < 4 && isTypeReferenceWithGenericArguments(t)) {`
	`9805`	`+ result += "<" + getTypeReferenceId(t, typeParameters, depth + 1) + ">";`
`9806`	`9806`	`}`
`9807`	`9807`	`else {`
`9808`	`9808`	`result += "-" + t.id;`