Remove unnecessary use of getOwnKeys

Andy Hanson · Andy Hanson · commit 4ae8df635a48 · 2017-04-11T14:19:11.000-07:00
Also, fix a typo.
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -1007,7 +1007,7 @@ namespace ts {
             let seenKnownKeys = 0;
             const nameColumn: string[] = [];
             const descriptionColumn: string[] = [];
-            const knownKesyCount = getOwnKeys(configurations.compilerOptions).length;
+            const knownKeysCount = getOwnKeys(configurations.compilerOptions).length;
             for (const category in categorizedOptions) {
                 if (nameColumn.length !== 0) {
                     nameColumn.push("");
@@ -1018,7 +1018,7 @@ namespace ts {
                 for (const option of categorizedOptions[category]) {
                     let optionName;
                     if (hasProperty(configurations.compilerOptions, option.name)) {
-                        optionName = `"${option.name}": ${JSON.stringify(configurations.compilerOptions[option.name])}${(seenKnownKeys += 1) === knownKesyCount ? "" : ","}`;
+                        optionName = `"${option.name}": ${JSON.stringify(configurations.compilerOptions[option.name])}${(seenKnownKeys += 1) === knownKeysCount ? "" : ","}`;
                     }
                     else {
                         optionName = `// "${option.name}": ${JSON.stringify(getDefaultValueForOption(option))},`;
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -943,7 +943,7 @@ namespace ts {
     export function assign<T1 extends MapLike<{}>>(t: T1, ...args: any[]): any;
     export function assign<T1 extends MapLike<{}>>(t: T1, ...args: any[]) {
         for (const arg of args) {
-            for (const p of getOwnKeys(arg)) {
+            for (const p in arg) if (hasProperty(arg, p)) {
                 t[p] = arg[p];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -943,7 +943,7 @@ namespace ts {`
`943`	`943`	`export function assign<T1 extends MapLike<{}>>(t: T1, ...args: any[]): any;`
`944`	`944`	`export function assign<T1 extends MapLike<{}>>(t: T1, ...args: any[]) {`
`945`	`945`	`for (const arg of args) {`
`946`		`- for (const p of getOwnKeys(arg)) {`
	`946`	`+ for (const p in arg) if (hasProperty(arg, p)) {`
`947`	`947`	`t[p] = arg[p];`
`948`	`948`	`}`
`949`	`949`	`}`