Error on 'const' in class expression (microsoft#25125)

Andy · web-flow · commit 40899eaf5b91 · 2018-06-21T09:57:52.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -27349,7 +27349,7 @@ namespace ts {
                 }
                 switch (modifier.kind) {
                     case SyntaxKind.ConstKeyword:
-                        if (node.kind !== SyntaxKind.EnumDeclaration && node.parent.kind === SyntaxKind.ClassDeclaration) {
+                        if (node.kind !== SyntaxKind.EnumDeclaration) {
                             return grammarErrorOnNode(node, Diagnostics.A_class_member_cannot_have_the_0_keyword, tokenToString(SyntaxKind.ConstKeyword));
                         }
                         break;
diff --git a/tests/baselines/reference/constInClassExpression.errors.txt b/tests/baselines/reference/constInClassExpression.errors.txt
@@ -0,0 +1,10 @@
+tests/cases/compiler/constInClassExpression.ts(2,11): error TS1248: A class member cannot have the 'const' keyword.
+
+
+==== tests/cases/compiler/constInClassExpression.ts (1 errors) ====
+    let C = class {
+        const a = 4;
+              ~
+!!! error TS1248: A class member cannot have the 'const' keyword.
+    };
+    
diff --git a/tests/baselines/reference/constInClassExpression.js b/tests/baselines/reference/constInClassExpression.js
@@ -0,0 +1,13 @@
+//// [constInClassExpression.ts]
+let C = class {
+    const a = 4;
+};
+
+
+//// [constInClassExpression.js]
+var C = /** @class */ (function () {
+    function class_1() {
+        this.a = 4;
+    }
+    return class_1;
+}());
diff --git a/tests/baselines/reference/constInClassExpression.symbols b/tests/baselines/reference/constInClassExpression.symbols
@@ -0,0 +1,9 @@
+=== tests/cases/compiler/constInClassExpression.ts ===
+let C = class {
+>C : Symbol(C, Decl(constInClassExpression.ts, 0, 3))
+
+    const a = 4;
+>a : Symbol(C.a, Decl(constInClassExpression.ts, 0, 15))
+
+};
+
diff --git a/tests/baselines/reference/constInClassExpression.types b/tests/baselines/reference/constInClassExpression.types
@@ -0,0 +1,11 @@
+=== tests/cases/compiler/constInClassExpression.ts ===
+let C = class {
+>C : typeof C
+>class {    const a = 4;} : typeof C
+
+    const a = 4;
+>a : number
+>4 : 4
+
+};
+
diff --git a/tests/cases/compiler/constInClassExpression.ts b/tests/cases/compiler/constInClassExpression.ts
@@ -0,0 +1,3 @@
+let C = class {
+    const a = 4;
+};

Original file line number	Diff line number	Diff line change
`@@ -27349,7 +27349,7 @@ namespace ts {`
`27349`	`27349`	`}`
`27350`	`27350`	`switch (modifier.kind) {`
`27351`	`27351`	`case SyntaxKind.ConstKeyword:`
`27352`		`- if (node.kind !== SyntaxKind.EnumDeclaration && node.parent.kind === SyntaxKind.ClassDeclaration) {`
	`27352`	`+ if (node.kind !== SyntaxKind.EnumDeclaration) {`
`27353`	`27353`	`return grammarErrorOnNode(node, Diagnostics.A_class_member_cannot_have_the_0_keyword, tokenToString(SyntaxKind.ConstKeyword));`
`27354`	`27354`	`}`
`27355`	`27355`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+let C = class {`
	`2`	`+ const a = 4;`
	`3`	`+};`