Make node type predicates public (microsoft#16121)

Andy · web-flow · commit 3eda9c627bff · 2017-05-31T07:45:13.000-07:00
* Make node type predicates public

* Rename isJSDocComment back to isJSDoc
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -21082,10 +21082,6 @@ namespace ts {
             }
         }
 
-        function isAccessor(kind: SyntaxKind): boolean {
-            return kind === SyntaxKind.GetAccessor || kind === SyntaxKind.SetAccessor;
-        }
-
         function checkInheritedPropertiesAreIdentical(type: InterfaceType, typeNode: Node): boolean {
             const baseTypes = getBaseTypes(type);
             if (baseTypes.length < 2) {
@@ -24555,7 +24551,7 @@ namespace ts {
         function checkGrammarStatementInAmbientContext(node: Node): boolean {
             if (isInAmbientContext(node)) {
                 // An accessors is already reported about the ambient context
-                if (isAccessor(node.parent.kind)) {
+                if (isAccessor(node.parent)) {
                     return getNodeLinks(node).hasReportedStatementInAmbientContext = true;
                 }
 
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -3908,7 +3908,7 @@ namespace ts {
             return bindingElement.right;
         }
 
-        if (isSpreadExpression(bindingElement)) {
+        if (isSpreadElement(bindingElement)) {
             // Recovery consistent with existing emit.
             return getInitializerOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.expression);
         }
@@ -3976,7 +3976,7 @@ namespace ts {
             return getTargetOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.left);
         }
 
-        if (isSpreadExpression(bindingElement)) {
+        if (isSpreadElement(bindingElement)) {
             // `a` in `[...a] = ...`
             return getTargetOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.expression);
         }
diff --git a/src/compiler/transformers/es2015.ts b/src/compiler/transformers/es2015.ts
@@ -3396,7 +3396,7 @@ namespace ts {
             else {
                 if (segments.length === 1) {
                     const firstElement = elements[0];
-                    return needsUniqueCopy && isSpreadExpression(firstElement) && firstElement.expression.kind !== SyntaxKind.ArrayLiteralExpression
+                    return needsUniqueCopy && isSpreadElement(firstElement) && firstElement.expression.kind !== SyntaxKind.ArrayLiteralExpression
                         ? createArraySlice(segments[0])
                         : segments[0];
                 }
@@ -3407,7 +3407,7 @@ namespace ts {
         }
 
         function partitionSpread(node: Expression) {
-            return isSpreadExpression(node)
+            return isSpreadElement(node)
                 ? visitSpanOfSpreads
                 : visitSpanOfNonSpreads;
         }
diff --git a/src/compiler/transformers/module/system.ts b/src/compiler/transformers/module/system.ts
@@ -1502,7 +1502,7 @@ namespace ts {
             if (isAssignmentExpression(node, /*excludeCompoundAssignment*/ true)) {
                 return hasExportedReferenceInDestructuringTarget(node.left);
             }
-            else if (isSpreadExpression(node)) {
+            else if (isSpreadElement(node)) {
                 return hasExportedReferenceInDestructuringTarget(node.expression);
             }
             else if (isObjectLiteralExpression(node)) {
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts

Original file line number	Diff line number	Diff line change
`@@ -21082,10 +21082,6 @@ namespace ts {`
`21082`	`21082`	`}`
`21083`	`21083`	`}`
`21084`	`21084`
`21085`		`- function isAccessor(kind: SyntaxKind): boolean {`
`21086`		`- return kind === SyntaxKind.GetAccessor \|\| kind === SyntaxKind.SetAccessor;`
`21087`		`- }`
`21088`		`-`
`21089`	`21085`	`function checkInheritedPropertiesAreIdentical(type: InterfaceType, typeNode: Node): boolean {`
`21090`	`21086`	`const baseTypes = getBaseTypes(type);`
`21091`	`21087`	`if (baseTypes.length < 2) {`
`@@ -24555,7 +24551,7 @@ namespace ts {`
`24555`	`24551`	`function checkGrammarStatementInAmbientContext(node: Node): boolean {`
`24556`	`24552`	`if (isInAmbientContext(node)) {`
`24557`	`24553`	`// An accessors is already reported about the ambient context`
`24558`		`- if (isAccessor(node.parent.kind)) {`
	`24554`	`+ if (isAccessor(node.parent)) {`
`24559`	`24555`	`return getNodeLinks(node).hasReportedStatementInAmbientContext = true;`
`24560`	`24556`	`}`
`24561`	`24557`
Original file line number	Diff line number	Diff line change
`@@ -3908,7 +3908,7 @@ namespace ts {`
`3908`	`3908`	`return bindingElement.right;`
`3909`	`3909`	`}`
`3910`	`3910`
`3911`		`- if (isSpreadExpression(bindingElement)) {`
	`3911`	`+ if (isSpreadElement(bindingElement)) {`
`3912`	`3912`	`// Recovery consistent with existing emit.`
`3913`	`3913`	`return getInitializerOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.expression);`
`3914`	`3914`	`}`
`@@ -3976,7 +3976,7 @@ namespace ts {`
`3976`	`3976`	`return getTargetOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.left);`
`3977`	`3977`	`}`
`3978`	`3978`
`3979`		`- if (isSpreadExpression(bindingElement)) {`
	`3979`	`+ if (isSpreadElement(bindingElement)) {`
`3980`	`3980`	// `a` in `[...a] = ...`
`3981`	`3981`	`return getTargetOfBindingOrAssignmentElement(<BindingOrAssignmentElement>bindingElement.expression);`
`3982`	`3982`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3396,7 +3396,7 @@ namespace ts {`
`3396`	`3396`	`else {`
`3397`	`3397`	`if (segments.length === 1) {`
`3398`	`3398`	`const firstElement = elements[0];`
`3399`		`- return needsUniqueCopy && isSpreadExpression(firstElement) && firstElement.expression.kind !== SyntaxKind.ArrayLiteralExpression`
	`3399`	`+ return needsUniqueCopy && isSpreadElement(firstElement) && firstElement.expression.kind !== SyntaxKind.ArrayLiteralExpression`
`3400`	`3400`	`? createArraySlice(segments[0])`
`3401`	`3401`	`: segments[0];`
`3402`	`3402`	`}`
`@@ -3407,7 +3407,7 @@ namespace ts {`
`3407`	`3407`	`}`
`3408`	`3408`
`3409`	`3409`	`function partitionSpread(node: Expression) {`
`3410`		`- return isSpreadExpression(node)`
	`3410`	`+ return isSpreadElement(node)`
`3411`	`3411`	`? visitSpanOfSpreads`
`3412`	`3412`	`: visitSpanOfNonSpreads;`
`3413`	`3413`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1502,7 +1502,7 @@ namespace ts {`
`1502`	`1502`	`if (isAssignmentExpression(node, /excludeCompoundAssignment/ true)) {`
`1503`	`1503`	`return hasExportedReferenceInDestructuringTarget(node.left);`
`1504`	`1504`	`}`
`1505`		`- else if (isSpreadExpression(node)) {`
	`1505`	`+ else if (isSpreadElement(node)) {`
`1506`	`1506`	`return hasExportedReferenceInDestructuringTarget(node.expression);`
`1507`	`1507`	`}`
`1508`	`1508`	`else if (isObjectLiteralExpression(node)) {`