remove TODO's

aozgaa · aozgaa · commit 3b6da51a81dc · 2017-04-05T11:39:59.000-07:00
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -4482,7 +4482,7 @@ namespace ts {
             newEndN = Math.max(newEnd2, newEnd2 + (newEnd1 - oldEnd2));
         }
 
-        return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength:*/ newEndN - oldStartN);
+        return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength*/ newEndN - oldStartN);
     }
 
     export function getTypeParameterOwner(d: Declaration): Declaration {
diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts
@@ -2897,7 +2897,6 @@ ${code}
                         }
                     }
                 }
-                // TODO: should be '==='?
             }
             else if (line === "" || lineLength === 0) {
                 // Previously blank lines between fourslash content caused it to be considered as 2 files,
diff --git a/src/harness/projectsRunner.ts b/src/harness/projectsRunner.ts
@@ -111,7 +111,6 @@ class ProjectRunner extends RunnerBase {
                 else if (url.indexOf(diskProjectPath) === 0) {
                     // Replace the disk specific path into the project root path
                     url = url.substr(diskProjectPath.length);
-                    // TODO: should be '!=='?
                     if (url.charCodeAt(0) !== ts.CharacterCodes.slash) {
                         url = "/" + url;
                     }
diff --git a/src/services/shims.ts b/src/services/shims.ts
@@ -37,7 +37,7 @@ namespace ts {
          *
          * Or undefined value if there was no change.
          */
-        getChangeRange(oldSnapshot: ScriptSnapshotShim): string;
+        getChangeRange(oldSnapshot: ScriptSnapshotShim): string | undefined;
 
         /** Releases all resources held by this script snapshot */
         dispose?(): void;
@@ -292,7 +292,6 @@ namespace ts {
         public getChangeRange(oldSnapshot: IScriptSnapshot): TextChangeRange {
             const oldSnapshotShim = <ScriptSnapshotShimAdapter>oldSnapshot;
             const encoded = this.scriptSnapshotShim.getChangeRange(oldSnapshotShim.scriptSnapshotShim);
-            // TODO: should this be '==='?
             if (encoded === null) {
                 return null;
             }
@@ -381,7 +380,6 @@ namespace ts {
 
         public getCompilationSettings(): CompilerOptions {
             const settingsJson = this.shimHost.getCompilationSettings();
-            // TODO: should this be '==='?
             if (settingsJson === null || settingsJson === "") {
                 throw Error("LanguageServiceShimHostAdapter.getCompilationSettings: empty compilationSettings");
             }

Original file line number	Diff line number	Diff line change
`@@ -4482,7 +4482,7 @@ namespace ts {`
`4482`	`4482`	`newEndN = Math.max(newEnd2, newEnd2 + (newEnd1 - oldEnd2));`
`4483`	`4483`	`}`
`4484`	`4484`
`4485`		`- return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /newLength:/ newEndN - oldStartN);`
	`4485`	`+ return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /newLength/ newEndN - oldStartN);`
`4486`	`4486`	`}`
`4487`	`4487`
`4488`	`4488`	`export function getTypeParameterOwner(d: Declaration): Declaration {`
Original file line number	Diff line number	Diff line change
`@@ -2897,7 +2897,6 @@ ${code}`
`2897`	`2897`	`}`
`2898`	`2898`	`}`
`2899`	`2899`	`}`
`2900`		`- // TODO: should be '==='?`
`2901`	`2900`	`}`
`2902`	`2901`	`else if (line === "" \|\| lineLength === 0) {`
`2903`	`2902`	`// Previously blank lines between fourslash content caused it to be considered as 2 files,`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,6 @@ class ProjectRunner extends RunnerBase {`
`111`	`111`	`else if (url.indexOf(diskProjectPath) === 0) {`
`112`	`112`	`// Replace the disk specific path into the project root path`
`113`	`113`	`url = url.substr(diskProjectPath.length);`
`114`		`- // TODO: should be '!=='?`
`115`	`114`	`if (url.charCodeAt(0) !== ts.CharacterCodes.slash) {`
`116`	`115`	`url = "/" + url;`
`117`	`116`	`}`