remove TODO comments

a-tarasyuk · a-tarasyuk · commit 371c3c630e5e · 2019-08-10T10:05:13.000+03:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -2693,7 +2693,7 @@ namespace ts {
             writeKeyword("function");
             emit(node.asteriskToken);
             writeSpace();
-            emitIdentifierName(node.name); // TODO: GH#18217
+            emitIdentifierName(node.name);
             emitSignatureAndBody(node, emitSignatureHead);
         }
 
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -1804,7 +1804,7 @@ namespace ts.server {
             }
             project.enablePluginsWithOptions(compilerOptions, this.currentPluginConfigOverrides);
             const filesToAdd = parsedCommandLine.fileNames.concat(project.getExternalFiles());
-            this.updateRootAndOptionsOfNonInferredProject(project, filesToAdd, fileNamePropertyReader, compilerOptions, parsedCommandLine.typeAcquisition!, parsedCommandLine.compileOnSave); // TODO: GH#18217
+            this.updateRootAndOptionsOfNonInferredProject(project, filesToAdd, fileNamePropertyReader, compilerOptions, parsedCommandLine.typeAcquisition!, parsedCommandLine.compileOnSave);
         }
 
         private updateNonInferredProjectFiles<T>(project: ExternalProject | ConfiguredProject, files: T[], propertyReader: FilePropertyReader<T>) {
diff --git a/src/testRunner/unittests/tsserver/cachingFileSystemInformation.ts b/src/testRunner/unittests/tsserver/cachingFileSystemInformation.ts
@@ -388,7 +388,7 @@ namespace ts.projectSystem {
                 const projectService = createProjectService(host);
                 const canonicalConfigPath = toCanonical(tsconfigFile.path);
                 const { configFileName } = projectService.openClientFile(file1.path);
-                assert.equal(configFileName, tsconfigFile.path as server.NormalizedPath, `should find config`); // TODO: GH#18217
+                assert.equal(configFileName, tsconfigFile.path as server.NormalizedPath, `should find config`);
                 checkNumberOfConfiguredProjects(projectService, 1);
                 const watchingRecursiveDirectories = [`${canonicalFrontendDir}/src`, `${canonicalFrontendDir}/types`, `${canonicalFrontendDir}/node_modules`].concat(getNodeModuleDirectories(getDirectoryPath(canonicalFrontendDir)));
 

Original file line number	Diff line number	Diff line change
`@@ -2693,7 +2693,7 @@ namespace ts {`
`2693`	`2693`	`writeKeyword("function");`
`2694`	`2694`	`emit(node.asteriskToken);`
`2695`	`2695`	`writeSpace();`
`2696`		`- emitIdentifierName(node.name); // TODO: GH#18217`
	`2696`	`+ emitIdentifierName(node.name);`
`2697`	`2697`	`emitSignatureAndBody(node, emitSignatureHead);`
`2698`	`2698`	`}`
`2699`	`2699`
Original file line number	Diff line number	Diff line change
`@@ -1804,7 +1804,7 @@ namespace ts.server {`
`1804`	`1804`	`}`
`1805`	`1805`	`project.enablePluginsWithOptions(compilerOptions, this.currentPluginConfigOverrides);`
`1806`	`1806`	`const filesToAdd = parsedCommandLine.fileNames.concat(project.getExternalFiles());`
`1807`		`- this.updateRootAndOptionsOfNonInferredProject(project, filesToAdd, fileNamePropertyReader, compilerOptions, parsedCommandLine.typeAcquisition!, parsedCommandLine.compileOnSave); // TODO: GH#18217`
	`1807`	`+ this.updateRootAndOptionsOfNonInferredProject(project, filesToAdd, fileNamePropertyReader, compilerOptions, parsedCommandLine.typeAcquisition!, parsedCommandLine.compileOnSave);`
`1808`	`1808`	`}`
`1809`	`1809`
`1810`	`1810`	`private updateNonInferredProjectFiles<T>(project: ExternalProject \| ConfiguredProject, files: T[], propertyReader: FilePropertyReader<T>) {`