Remove unnecessary call to getApparentType (microsoft#17788)

Andy · web-flow · commit 34a55899bee1 · 2017-08-16T10:04:51.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -22918,10 +22918,7 @@ namespace ts {
                     // index access
                     if (node.parent.kind === SyntaxKind.ElementAccessExpression && (<ElementAccessExpression>node.parent).argumentExpression === node) {
                         const objectType = getTypeOfExpression((<ElementAccessExpression>node.parent).expression);
-                        if (objectType === unknownType) return undefined;
-                        const apparentType = getApparentType(objectType);
-                        if (apparentType === unknownType) return undefined;
-                        return getPropertyOfType(apparentType, (<NumericLiteral>node).text as __String);
+                        return getPropertyOfType(objectType, (<NumericLiteral>node).text as __String);
                     }
                     break;
             }

Original file line number	Diff line number	Diff line change
`@@ -22918,10 +22918,7 @@ namespace ts {`
`22918`	`22918`	`// index access`
`22919`	`22919`	`if (node.parent.kind === SyntaxKind.ElementAccessExpression && (<ElementAccessExpression>node.parent).argumentExpression === node) {`
`22920`	`22920`	`const objectType = getTypeOfExpression((<ElementAccessExpression>node.parent).expression);`
`22921`		`- if (objectType === unknownType) return undefined;`
`22922`		`- const apparentType = getApparentType(objectType);`
`22923`		`- if (apparentType === unknownType) return undefined;`
`22924`		`- return getPropertyOfType(apparentType, (<NumericLiteral>node).text as __String);`
	`22921`	`+ return getPropertyOfType(objectType, (<NumericLiteral>node).text as __String);`
`22925`	`22922`	`}`
`22926`	`22923`	`break;`
`22927`	`22924`	`}`