Actuallt preserve nonblock for of statements in forofs with object rest (microsoft#23122)

weswigham · web-flow · commit 343bb5ac70b5 · 2018-04-03T13:32:42.000-07:00
diff --git a/src/compiler/transformers/esnext.ts b/src/compiler/transformers/esnext.ts
@@ -304,6 +304,11 @@ namespace ts {
                     bodyLocation = node.statement;
                     statementsLocation = node.statement.statements;
                 }
+                else if (node.statement) {
+                    append(statements, node.statement);
+                    bodyLocation = node.statement;
+                    statementsLocation = node.statement;
+                }
                 return updateForOf(
                     node,
                     node.awaitModifier,
diff --git a/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.js b/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.js
@@ -0,0 +1,21 @@
+//// [forLoopWithDestructuringDoesNotElideFollowingStatement.ts]
+let array = [{a: 0, b: 1}]
+for (let { a, ...rest } of array)
+    void a
+
+//// [forLoopWithDestructuringDoesNotElideFollowingStatement.js]
+var __rest = (this && this.__rest) || function (s, e) {
+    var t = {};
+    for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
+        t[p] = s[p];
+    if (s != null && typeof Object.getOwnPropertySymbols === "function")
+        for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) if (e.indexOf(p[i]) < 0)
+            t[p[i]] = s[p[i]];
+    return t;
+};
+var array = [{ a: 0, b: 1 }];
+for (var _i = 0, array_1 = array; _i < array_1.length; _i++) {
+    var _a = array_1[_i];
+    var a = _a.a, rest = __rest(_a, ["a"]);
+    void a;
+}
diff --git a/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.symbols b/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.symbols
@@ -0,0 +1,14 @@
+=== tests/cases/compiler/forLoopWithDestructuringDoesNotElideFollowingStatement.ts ===
+let array = [{a: 0, b: 1}]
+>array : Symbol(array, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 0, 3))
+>a : Symbol(a, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 0, 14))
+>b : Symbol(b, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 0, 19))
+
+for (let { a, ...rest } of array)
+>a : Symbol(a, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 1, 10))
+>rest : Symbol(rest, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 1, 13))
+>array : Symbol(array, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 0, 3))
+
+    void a
+>a : Symbol(a, Decl(forLoopWithDestructuringDoesNotElideFollowingStatement.ts, 1, 10))
+
diff --git a/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.types b/tests/baselines/reference/forLoopWithDestructuringDoesNotElideFollowingStatement.types
@@ -0,0 +1,19 @@
+=== tests/cases/compiler/forLoopWithDestructuringDoesNotElideFollowingStatement.ts ===
+let array = [{a: 0, b: 1}]
+>array : { a: number; b: number; }[]
+>[{a: 0, b: 1}] : { a: number; b: number; }[]
+>{a: 0, b: 1} : { a: number; b: number; }
+>a : number
+>0 : 0
+>b : number
+>1 : 1
+
+for (let { a, ...rest } of array)
+>a : number
+>rest : { b: number; }
+>array : { a: number; b: number; }[]
+
+    void a
+>void a : undefined
+>a : number
+
diff --git a/tests/cases/compiler/forLoopWithDestructuringDoesNotElideFollowingStatement.ts b/tests/cases/compiler/forLoopWithDestructuringDoesNotElideFollowingStatement.ts
@@ -0,0 +1,3 @@
+let array = [{a: 0, b: 1}]
+for (let { a, ...rest } of array)
+    void a

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+let array = [{a: 0, b: 1}]`
	`2`	`+for (let { a, ...rest } of array)`
	`3`	`+ void a`