Remove getDefaultLibFilename from the LS host interface as its result is never honored by the LS.

mhegazy · mhegazy · commit 3434aa0bddc8 · 2015-01-14T17:20:27.000-08:00
The LS operate only on a fixed list of files initialized by the host's getScriptFileNames(), if a file is not in this list, it will not be queried from the host, rather considered a missing file. Thus the result of getDefaultLibFilename()is either in the list, or will be ignored.
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -217,10 +217,6 @@ module Harness.LanguageService {
             return "";
         }
 
-        public getDefaultLibFilename(): string {
-            return "";
-        }
-
         public getScriptFileNames(): string {
             var fileNames: string[] = [];
             ts.forEachKey(this.fileNameToScript, (fileName) => { fileNames.push(fileName); });
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -853,7 +853,6 @@ module ts {
         getLocalizedDiagnosticMessages?(): any;
         getCancellationToken?(): CancellationToken;
         getCurrentDirectory(): string;
-        getDefaultLibFilename(options: CompilerOptions): string;
         log? (s: string): void;
         trace? (s: string): void;
         error? (s: string): void;
@@ -1964,21 +1963,14 @@ module ts {
 
         function createCompilerHost(): CompilerHost {
             return {
-                getSourceFile: (filename, languageVersion) => {
-                    return getSourceFile(filename);
-                },
+                getSourceFile: getSourceFile,
                 getCancellationToken: () => cancellationToken,
-                getCanonicalFileName: (filename) => useCaseSensitivefilenames ? filename : filename.toLowerCase(),
+                getCanonicalFileName: filename => useCaseSensitivefilenames ? filename : filename.toLowerCase(),
                 useCaseSensitiveFileNames: () => useCaseSensitivefilenames,
                 getNewLine: () => "\r\n",
-                getDefaultLibFilename: (options): string => {
-                    return host.getDefaultLibFilename(options);
-                },
-                writeFile: (filename, data, writeByteOrderMark) => {
-                },
-                getCurrentDirectory: (): string => {
-                    return host.getCurrentDirectory();
-                }
+                getDefaultLibFilename: getDefaultLibraryFilename,
+                writeFile: (filename, data, writeByteOrderMark) => { },
+                getCurrentDirectory: () => host.getCurrentDirectory()
             };
         }
 
diff --git a/src/services/shims.ts b/src/services/shims.ts
@@ -55,7 +55,6 @@ module ts {
         getLocalizedDiagnosticMessages(): string;
         getCancellationToken(): CancellationToken;
         getCurrentDirectory(): string;
-        getDefaultLibFilename(options: string): string;
     }
 
     ///
@@ -275,10 +274,6 @@ module ts {
             return this.shimHost.getCancellationToken();
         }
 
-        public getDefaultLibFilename(options: CompilerOptions): string {
-            return this.shimHost.getDefaultLibFilename(JSON.stringify(options));
-        }
-
         public getCurrentDirectory(): string {
             return this.shimHost.getCurrentDirectory();
         }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ module ts {`
`55`	`55`	`getLocalizedDiagnosticMessages(): string;`
`56`	`56`	`getCancellationToken(): CancellationToken;`
`57`	`57`	`getCurrentDirectory(): string;`
`58`		`- getDefaultLibFilename(options: string): string;`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`///`
`@@ -275,10 +274,6 @@ module ts {`
`275`	`274`	`return this.shimHost.getCancellationToken();`
`276`	`275`	`}`
`277`	`276`
`278`		`- public getDefaultLibFilename(options: CompilerOptions): string {`
`279`		`- return this.shimHost.getDefaultLibFilename(JSON.stringify(options));`
`280`		`- }`
`281`		`-`
`282`	`277`	`public getCurrentDirectory(): string {`
`283`	`278`	`return this.shimHost.getCurrentDirectory();`
`284`	`279`	`}`