Remove added type predicates

sandersn · sandersn · commit 2fc14d8ae81c · 2017-09-05T10:39:32.000-07:00
I forgot that 'f(x): x is T' implies that x is *not* T if f returns
false.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -9781,7 +9781,7 @@ namespace ts {
             return type.flags & TypeFlags.TypeParameter && !getConstraintFromTypeParameter(<TypeParameter>type);
         }
 
-        function isTypeReferenceWithGenericArguments(type: Type): type is TypeReference {
+        function isTypeReferenceWithGenericArguments(type: Type): boolean {
             return getObjectFlags(type) & ObjectFlags.Reference && some((<TypeReference>type).typeArguments, t => isUnconstrainedTypeParameter(t) || isTypeReferenceWithGenericArguments(t));
         }
 
@@ -9801,7 +9801,7 @@ namespace ts {
                     result += "=" + index;
                 }
                 else if (depth < 4 && isTypeReferenceWithGenericArguments(t)) {
-                    result += "<" + getTypeReferenceId(t, typeParameters, depth + 1) + ">";
+                    result += "<" + getTypeReferenceId(t as TypeReference, typeParameters, depth + 1) + ">";
                 }
                 else {
                     result += "-" + t.id;
@@ -10052,7 +10052,7 @@ namespace ts {
                 getUnionType(types, /*subtypeReduction*/ true);
         }
 
-        function isArrayType(type: Type): type is TypeReference {
+        function isArrayType(type: Type): boolean {
             return getObjectFlags(type) & ObjectFlags.Reference && (<TypeReference>type).target === globalArrayType;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -9781,7 +9781,7 @@ namespace ts {`
`9781`	`9781`	`return type.flags & TypeFlags.TypeParameter && !getConstraintFromTypeParameter(<TypeParameter>type);`
`9782`	`9782`	`}`
`9783`	`9783`
`9784`		`- function isTypeReferenceWithGenericArguments(type: Type): type is TypeReference {`
	`9784`	`+ function isTypeReferenceWithGenericArguments(type: Type): boolean {`
`9785`	`9785`	`return getObjectFlags(type) & ObjectFlags.Reference && some((<TypeReference>type).typeArguments, t => isUnconstrainedTypeParameter(t) \|\| isTypeReferenceWithGenericArguments(t));`
`9786`	`9786`	`}`
`9787`	`9787`
`@@ -9801,7 +9801,7 @@ namespace ts {`
`9801`	`9801`	`result += "=" + index;`
`9802`	`9802`	`}`
`9803`	`9803`	`else if (depth < 4 && isTypeReferenceWithGenericArguments(t)) {`
`9804`		`- result += "<" + getTypeReferenceId(t, typeParameters, depth + 1) + ">";`
	`9804`	`+ result += "<" + getTypeReferenceId(t as TypeReference, typeParameters, depth + 1) + ">";`
`9805`	`9805`	`}`
`9806`	`9806`	`else {`
`9807`	`9807`	`result += "-" + t.id;`
`@@ -10052,7 +10052,7 @@ namespace ts {`
`10052`	`10052`	`getUnionType(types, /subtypeReduction/ true);`
`10053`	`10053`	`}`
`10054`	`10054`
`10055`		`- function isArrayType(type: Type): type is TypeReference {`
	`10055`	`+ function isArrayType(type: Type): boolean {`
`10056`	`10056`	`return getObjectFlags(type) & ObjectFlags.Reference && (<TypeReference>type).target === globalArrayType;`
`10057`	`10057`	`}`
`10058`	`10058`