Merge pull request microsoft#11401 from Microsoft/completionInObjectLiteralAssignment

sheetalkamat · web-flow · commit 2f5e7142cb7c · 2016-10-05T17:02:58.000-07:00
Fix incorrect returning of completion entries when in string literal of property assignment expression
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -138,7 +138,9 @@ namespace ts.Completions {
                 return undefined;
             }
 
-            if (node.parent.kind === SyntaxKind.PropertyAssignment && node.parent.parent.kind === SyntaxKind.ObjectLiteralExpression) {
+            if (node.parent.kind === SyntaxKind.PropertyAssignment &&
+                node.parent.parent.kind === SyntaxKind.ObjectLiteralExpression &&
+                (<PropertyAssignment>node.parent).name === node) {
                 // Get quoted name of properties of the object literal expression
                 // i.e. interface ConfigFiles {
                 //          'jspm:dev': string
diff --git a/tests/cases/fourslash/completionListInObjectLiteralPropertyAssignment.ts b/tests/cases/fourslash/completionListInObjectLiteralPropertyAssignment.ts
@@ -0,0 +1,15 @@
+/// <reference path='fourslash.ts' />
+
+////var foo;
+////interface I {
+////    metadata: string;
+////    wat: string;
+////}
+////var x: I = {
+////    metadata: "/*1*/
+////}
+
+goTo.marker('1');
+
+verify.not.completionListContains("metadata");
+verify.not.completionListContains("wat");
