allow BindingPattern in BindingRestElement

ajafff · ajafff · commit 2ea3123dbd4b · 2018-07-27T15:58:02.000+02:00
Part of microsoft#6275
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -29188,10 +29188,6 @@ namespace ts {
                 }
                 checkGrammarForDisallowedTrailingComma(elements, Diagnostics.A_rest_parameter_or_binding_pattern_may_not_have_a_trailing_comma);
 
-                if (node.name.kind === SyntaxKind.ArrayBindingPattern || node.name.kind === SyntaxKind.ObjectBindingPattern) {
-                    return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_contain_a_binding_pattern);
-                }
-
                 if (node.propertyName) {
                     return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_have_a_property_name);
                 }
diff --git a/tests/baselines/reference/restElementWithBindingPattern.errors.txt b/tests/baselines/reference/restElementWithBindingPattern.errors.txt
diff --git a/tests/baselines/reference/restElementWithBindingPattern2.errors.txt b/tests/baselines/reference/restElementWithBindingPattern2.errors.txt
@@ -1,10 +1,7 @@
-tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts(1,9): error TS2501: A rest element cannot contain a binding pattern.
 tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts(1,16): error TS2459: Type 'number[]' has no property 'b' and no string index signature.
 
 
-==== tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts (2 errors) ====
+==== tests/cases/conformance/es6/destructuring/restElementWithBindingPattern2.ts (1 errors) ====
     var [...{0: a, b }] = [0, 1];
-            ~~~~~~~~~~
-!!! error TS2501: A rest element cannot contain a binding pattern.
                    ~
 !!! error TS2459: Type 'number[]' has no property 'b' and no string index signature.

Original file line number	Diff line number	Diff line change
`@@ -29188,10 +29188,6 @@ namespace ts {`
`29188`	`29188`	`}`
`29189`	`29189`	`checkGrammarForDisallowedTrailingComma(elements, Diagnostics.A_rest_parameter_or_binding_pattern_may_not_have_a_trailing_comma);`
`29190`	`29190`
`29191`		`- if (node.name.kind === SyntaxKind.ArrayBindingPattern \|\| node.name.kind === SyntaxKind.ObjectBindingPattern) {`
`29192`		`- return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_contain_a_binding_pattern);`
`29193`		`- }`
`29194`		`-`
`29195`	`29191`	`if (node.propertyName) {`
`29196`	`29192`	`return grammarErrorOnNode(node.name, Diagnostics.A_rest_element_cannot_have_a_property_name);`
`29197`	`29193`	`}`