Since there arent any user given extensions, have extensions start with "." like before

sheetalkamat · sheetalkamat · commit 2d3a345fd3a5 · 2015-10-28T16:24:53.000-07:00
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -515,7 +515,7 @@ namespace ts {
                         if (!hasConflictingExtension) {
                             // Add the file only if there is no higher priority extension file already included
                             // eg. when a.d.ts and a.js are present in the folder, include only a.d.ts not a.js
-                            const baseName = fileName.substr(0, fileName.length - currentExtension.length - 1);
+                            const baseName = fileName.substr(0, fileName.length - currentExtension.length);
                             if (!hasProperty(filesSeen, baseName)) {
                                 filesSeen[baseName] = true;
                                 fileNames.push(fileName);
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -721,15 +721,15 @@ namespace ts {
 
     export function fileExtensionIs(path: string, extension: string): boolean {
         let pathLen = path.length;
-        let extLen = extension.length + 1;
-        return pathLen > extLen && path.substr(pathLen - extLen, extLen) === "." + extension;
+        let extLen = extension.length;
+        return pathLen > extLen && path.substr(pathLen - extLen, extLen) === extension;
     }
 
     /**
      *  List of supported extensions in order of file resolution precedence.
      */
-    export const supportedTypeScriptExtensions = ["ts", "tsx", "d.ts"];
-    export const supportedJavascriptExtensions = ["js", "jsx"];
+    export const supportedTypeScriptExtensions = [".ts", ".tsx", ".d.ts"];
+    export const supportedJavascriptExtensions = [".js", ".jsx"];
     export const supportedExtensionsWhenAllowedJs = supportedTypeScriptExtensions.concat(supportedJavascriptExtensions);
 
     export function getSupportedExtensions(options?: CompilerOptions): string[] {
@@ -747,11 +747,11 @@ namespace ts {
         return false;
     }
 
-    export const extensionsToRemove = ["d.ts", "ts", "js", "tsx", "jsx"]; 
+    export const extensionsToRemove = [".d.ts", ".ts", ".js", ".tsx", ".jsx"];
     export function removeFileExtension(path: string): string {
         for (let ext of extensionsToRemove) {
             if (fileExtensionIs(path, ext)) {
-                return path.substr(0, path.length - ext.length - 1);
+                return path.substr(0, path.length - ext.length);
             }
         }
         return path;
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -669,7 +669,7 @@ namespace ts {
             sourceFile.bindDiagnostics = [];
             sourceFile.languageVersion = languageVersion;
             sourceFile.fileName = normalizePath(fileName);
-            sourceFile.flags = fileExtensionIs(sourceFile.fileName, "d.ts") ? NodeFlags.DeclarationFile : 0;
+            sourceFile.flags = fileExtensionIs(sourceFile.fileName, ".d.ts") ? NodeFlags.DeclarationFile : 0;
             sourceFile.languageVariant = getLanguageVariant(sourceFile.fileName);
 
             return sourceFile;
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -73,7 +73,7 @@ namespace ts {
         return forEach(supportedExtensions, tryLoad);
 
         function tryLoad(ext: string): string {
-            let fileName = fileExtensionIs(candidate, ext) ? candidate : candidate + "." + ext;
+            let fileName = fileExtensionIs(candidate, ext) ? candidate : candidate + ext;
             if (host.fileExists(fileName)) {
                 return fileName;
             }
@@ -165,13 +165,13 @@ namespace ts {
         while (true) {
             searchName = normalizePath(combinePaths(searchPath, moduleName));
             referencedSourceFile = forEach(getSupportedExtensions(compilerOptions), extension => {
-                if (extension === "tsx" && !compilerOptions.jsx) {
+                if (extension === ".tsx" && !compilerOptions.jsx) {
                     // resolve .tsx files only if jsx support is enabled 
                     // 'logical not' handles both undefined and None cases
                     return undefined;
                 }
 
-                let candidate = searchName + "." + extension;
+                let candidate = searchName + extension;
                 if (host.fileExists(candidate)) {
                     return candidate;
                 }
@@ -964,7 +964,7 @@ namespace ts {
                         diagnostic = Diagnostics.File_0_not_found;
                         diagnosticArgument = [fileName];
                     }
-                    else if (!forEach(getSupportedExtensions(options), extension => findSourceFile(fileName + "." + extension, isDefaultLib, supportedExtensions, refFile, refPos, refEnd))) {
+                    else if (!forEach(getSupportedExtensions(options), extension => findSourceFile(fileName + extension, isDefaultLib, supportedExtensions, refFile, refPos, refEnd))) {
                         // (TODO: shkamat) Should this message be different given we support multiple extensions
                         diagnostic = Diagnostics.File_0_not_found;
                         fileName += ".ts";
@@ -1077,7 +1077,7 @@ namespace ts {
                                 let start = getTokenPosOfNode(file.imports[i], file);
                                 fileProcessingDiagnostics.add(createFileDiagnostic(file, start, file.imports[i].end - start, Diagnostics.Exported_external_package_typings_file_0_is_not_a_module_Please_contact_the_package_author_to_update_the_package_definition, importedFile.fileName));
                             }
-                            else if (!fileExtensionIs(importedFile.fileName, "d.ts")) {
+                            else if (!fileExtensionIs(importedFile.fileName, ".d.ts")) {
                                 let start = getTokenPosOfNode(file.imports[i], file);
                                 fileProcessingDiagnostics.add(createFileDiagnostic(file, start, file.imports[i].end - start, Diagnostics.Exported_external_package_typings_can_only_be_in_d_ts_files_Please_contact_the_package_author_to_update_the_package_definition));
                             }
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -2143,7 +2143,7 @@ namespace ts {
     }
 
     export function isTsx(fileName: string) {
-        return fileExtensionIs(fileName, "tsx");
+        return fileExtensionIs(fileName, ".tsx");
     }
 
     /**
diff --git a/src/harness/compilerRunner.ts b/src/harness/compilerRunner.ts
@@ -151,7 +151,7 @@ class CompilerBaselineRunner extends RunnerBase {
             });
 
             it("Correct JS output for " + fileName, () => {
-                if (!(units.length === 1 && ts.fileExtensionIs(lastUnit.name, "d.ts")) && this.emit) {
+                if (!(units.length === 1 && ts.fileExtensionIs(lastUnit.name, ".d.ts")) && this.emit) {
                     if (result.files.length === 0 && result.errors.length === 0) {
                         throw new Error("Expected at least one js file to be emitted or at least one error to be created.");
                     }
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -1875,7 +1875,7 @@ namespace ts {
         let compilerHost: CompilerHost = {
             getSourceFile: (fileName, target) => fileName === normalizeSlashes(inputFileName) ? sourceFile : undefined,
             writeFile: (name, text, writeByteOrderMark) => {
-                if (fileExtensionIs(name, "map")) {
+                if (fileExtensionIs(name, ".map")) {
                     Debug.assert(sourceMapText === undefined, `Unexpected multiple source map outputs for the file '${name}'`);
                     sourceMapText = text;
                 }
diff --git a/tests/baselines/reference/jsFileCompilationWithMapFileAsJs.errors.txt b/tests/baselines/reference/jsFileCompilationWithMapFileAsJs.errors.txt
@@ -1,9 +1,9 @@
 error TS5055: Cannot write file 'tests/cases/compiler/b.js' which is one of the input files.
-error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts', 'js', 'jsx'.
+error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts', '.js', '.jsx'.
 
 
 !!! error TS5055: Cannot write file 'tests/cases/compiler/b.js' which is one of the input files.
-!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts', 'js', 'jsx'.
+!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts', '.js', '.jsx'.
 ==== tests/cases/compiler/a.ts (0 errors) ====
     
     class c {
diff --git a/tests/baselines/reference/jsFileCompilationWithMapFileAsJsWithInlineSourceMap.errors.txt b/tests/baselines/reference/jsFileCompilationWithMapFileAsJsWithInlineSourceMap.errors.txt
@@ -1,9 +1,9 @@
 error TS5055: Cannot write file 'tests/cases/compiler/b.js' which is one of the input files.
-error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts', 'js', 'jsx'.
+error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts', '.js', '.jsx'.
 
 
 !!! error TS5055: Cannot write file 'tests/cases/compiler/b.js' which is one of the input files.
-!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts', 'js', 'jsx'.
+!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts', '.js', '.jsx'.
 ==== tests/cases/compiler/a.ts (0 errors) ====
     
     class c {
diff --git a/tests/baselines/reference/jsFileCompilationWithMapFileAsJsWithOutDir.errors.txt b/tests/baselines/reference/jsFileCompilationWithMapFileAsJsWithOutDir.errors.txt
@@ -1,9 +1,9 @@
-error TS6054: File 'tests/cases/compiler/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
-error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'tests/cases/compiler/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
+error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
-!!! error TS6054: File 'tests/cases/compiler/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
-!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'tests/cases/compiler/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
+!!! error TS6054: File 'tests/cases/compiler/b.js.map' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 ==== tests/cases/compiler/a.ts (0 errors) ====
     
     class c {
diff --git a/tests/baselines/reference/jsFileCompilationWithoutJsExtensions.errors.txt b/tests/baselines/reference/jsFileCompilationWithoutJsExtensions.errors.txt
@@ -1,6 +1,6 @@
-error TS6054: File 'tests/cases/compiler/a.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'tests/cases/compiler/a.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
-!!! error TS6054: File 'tests/cases/compiler/a.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'tests/cases/compiler/a.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 ==== tests/cases/compiler/a.js (0 errors) ====
     declare var v;
diff --git a/tests/baselines/reference/project/invalidRootFile/amd/invalidRootFile.errors.txt b/tests/baselines/reference/project/invalidRootFile/amd/invalidRootFile.errors.txt
@@ -1,6 +1,6 @@
 error TS6053: File 'a.ts' not found.
-error TS6054: File 'a.t' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'a.t' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
 !!! error TS6053: File 'a.ts' not found.
-!!! error TS6054: File 'a.t' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'a.t' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
diff --git a/tests/baselines/reference/project/invalidRootFile/node/invalidRootFile.errors.txt b/tests/baselines/reference/project/invalidRootFile/node/invalidRootFile.errors.txt
@@ -1,6 +1,6 @@
 error TS6053: File 'a.ts' not found.
-error TS6054: File 'a.t' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'a.t' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
 !!! error TS6053: File 'a.ts' not found.
-!!! error TS6054: File 'a.t' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'a.t' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecified/amd/jsFileCompilationDifferentNamesSpecified.errors.txt b/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecified/amd/jsFileCompilationDifferentNamesSpecified.errors.txt
@@ -1,6 +1,6 @@
-error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
-!!! error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 ==== DifferentNamesSpecified/a.ts (0 errors) ====
     var test = 10;
diff --git a/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecified/node/jsFileCompilationDifferentNamesSpecified.errors.txt b/tests/baselines/reference/project/jsFileCompilationDifferentNamesSpecified/node/jsFileCompilationDifferentNamesSpecified.errors.txt
@@ -1,6 +1,6 @@
-error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 
 
-!!! error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are 'ts', 'tsx', 'd.ts'.
+!!! error TS6054: File 'DifferentNamesSpecified/b.js' has unsupported extension. The only supported extensions are '.ts', '.tsx', '.d.ts'.
 ==== DifferentNamesSpecified/a.ts (0 errors) ====
     var test = 10;
diff --git a/tests/cases/unittests/moduleResolution.ts b/tests/cases/unittests/moduleResolution.ts
@@ -38,7 +38,7 @@ module ts {
         function testLoadAsFile(containingFileName: string, moduleFileNameNoExt: string, moduleName: string): void {
             for (let ext of supportedTypeScriptExtensions) {
                 let containingFile = { name: containingFileName }
-                let moduleFile = { name: moduleFileNameNoExt + "." + ext }
+                let moduleFile = { name: moduleFileNameNoExt + ext }
                 let resolution = nodeModuleNameResolver(moduleName, containingFile.name, supportedTypeScriptExtensions, createModuleResolutionHost(containingFile, moduleFile));                
                 assert.equal(resolution.resolvedModule.resolvedFileName, moduleFile.name);
                 assert.equal(!!resolution.resolvedModule.isExternalLibraryImport, false);
@@ -50,7 +50,7 @@ module ts {
                         break;
                     }
                     else {
-                        failedLookupLocations.push(normalizePath(getRootLength(moduleName) === 0 ? combinePaths(dir, moduleName) : moduleName) + "." + e);
+                        failedLookupLocations.push(normalizePath(getRootLength(moduleName) === 0 ? combinePaths(dir, moduleName) : moduleName) + e);
                     }
                 }
                 

Original file line number	Diff line number	Diff line change
`@@ -2143,7 +2143,7 @@ namespace ts {`
`2143`	`2143`	`}`
`2144`	`2144`
`2145`	`2145`	`export function isTsx(fileName: string) {`
`2146`		`- return fileExtensionIs(fileName, "tsx");`
	`2146`	`+ return fileExtensionIs(fileName, ".tsx");`
`2147`	`2147`	`}`
`2148`	`2148`
`2149`	`2149`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ class CompilerBaselineRunner extends RunnerBase {`
`151`	`151`	`});`
`152`	`152`
`153`	`153`	`it("Correct JS output for " + fileName, () => {`
`154`		`- if (!(units.length === 1 && ts.fileExtensionIs(lastUnit.name, "d.ts")) && this.emit) {`
	`154`	`+ if (!(units.length === 1 && ts.fileExtensionIs(lastUnit.name, ".d.ts")) && this.emit) {`
`155`	`155`	`if (result.files.length === 0 && result.errors.length === 0) {`
`156`	`156`	`throw new Error("Expected at least one js file to be emitted or at least one error to be created.");`
`157`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1875,7 +1875,7 @@ namespace ts {`
`1875`	`1875`	`let compilerHost: CompilerHost = {`
`1876`	`1876`	`getSourceFile: (fileName, target) => fileName === normalizeSlashes(inputFileName) ? sourceFile : undefined,`
`1877`	`1877`	`writeFile: (name, text, writeByteOrderMark) => {`
`1878`		`- if (fileExtensionIs(name, "map")) {`
	`1878`	`+ if (fileExtensionIs(name, ".map")) {`
`1879`	`1879`	Debug.assert(sourceMapText === undefined, `Unexpected multiple source map outputs for the file '${name}'`);
`1880`	`1880`	`sourceMapText = text;`
`1881`	`1881`	`}`