Support '/' as a trigger character in path completions (microsoft#24042)

Andy · web-flow · commit 2be6aaf8137a · 2018-05-10T16:50:26.000-07:00
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -2218,7 +2218,9 @@ namespace ts.Completions {
                 // Opening JSX tag
                 return contextToken.kind === SyntaxKind.LessThanToken && contextToken.parent.kind !== SyntaxKind.BinaryExpression;
             case "/":
-                return isJsxClosingElement(contextToken.parent);
+                return isStringLiteralLike(contextToken)
+                    ? !!tryGetImportFromModuleSpecifier(contextToken)
+                    : contextToken.kind === SyntaxKind.SlashToken && isJsxClosingElement(contextToken.parent);
             default:
                 return Debug.assertNever(triggerCharacter);
         }
diff --git a/tests/cases/fourslash/completionsTriggerCharacter.ts b/tests/cases/fourslash/completionsTriggerCharacter.ts
@@ -9,16 +9,20 @@
 
 ////// "/*quoteInComment*/ </*lessInComment*/
 
+// @Filename: /foo/importMe.ts
+////whatever
+
 // @Filename: /a.tsx
 ////declare namespace JSX {
 ////    interface Element {}
 ////    interface IntrinsicElements {
 ////        div: {};
 ////    }
 ////}
-////const ctr = </*openTag*/
-////const less = 1 </*lessThan*/
-////const closeTag = <div> foo <//*closeTag*/
+////const ctr = </*openTag*/;
+////const less = 1 </*lessThan*/;
+////const closeTag = <div> foo <//*closeTag*/;
+////import something from "./foo//*path*/";
 ////const divide = 1 //*divide*/
 
 verify.completions(
@@ -37,5 +41,6 @@ verify.completions(
     { marker: "openTag", includes: "div", triggerCharacter: "<" },
     { marker: "lessThan", exact: undefined, triggerCharacter: "<" },
     { marker: "closeTag", exact: "div", triggerCharacter: "/" },
+    { marker: "path", exact: "importMe", triggerCharacter: "/", isNewIdentifierLocation: true },
     { marker: "divide", exact: undefined, triggerCharacter: "/" },
 );
