Skip to content

Commit 2bc35c1

Browse files
authored
Merge pull request microsoft#9333 from Microsoft/fix-case-of-gulpfile-dependencies
Fix case of gulpfile dependencies
2 parents be6c34f + ca25fea commit 2bc35c1

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

Gulpfile.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/// <reference path="scripts/types/ambient.d.ts" />
2+
/// <reference types="q" />
23

34
import * as cp from "child_process";
45
import * as path from "path";
@@ -25,7 +26,7 @@ declare global {
2526
type Promise<T> = Q.Promise<T>;
2627
}
2728
import del = require("del");
28-
import mkdirP = require("mkdirP");
29+
import mkdirP = require("mkdirp");
2930
import minimist = require("minimist");
3031
import browserify = require("browserify");
3132
import through2 = require("through2");
@@ -67,7 +68,9 @@ const cmdLineOptions = minimist(process.argv.slice(2), {
6768
function exec(cmd: string, args: string[], complete: () => void = (() => {}), error: (e: any, status: number) => void = (() => {})) {
6869
console.log(`${cmd} ${args.join(" ")}`);
6970
// TODO (weswig): Update child_process types to add windowsVerbatimArguments to the type definition
70-
const ex = cp.spawn(isWin ? "cmd" : "/bin/sh", [isWin ? "/c" : "-c", cmd, ...args], { stdio: "inherit", windowsVerbatimArguments: true } as any);
71+
const subshellFlag = isWin ? "/c" : "-c";
72+
const command = isWin ? [cmd, ...args] : [`${cmd} ${args.join(" ")}`];
73+
const ex = cp.spawn(isWin ? "cmd" : "/bin/sh", [subshellFlag, ...command], { stdio: "inherit", windowsVerbatimArguments: true } as any);
7174
ex.on("exit", (code) => code === 0 ? complete() : error(/*e*/ undefined, code));
7275
ex.on("error", error);
7376
}

src/server/tsconfig.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
"stripInternal": true
99
},
1010
"files": [
11+
"../services/shims.ts",
12+
"../services/utilities.ts",
1113
"node.d.ts",
1214
"editorServices.ts",
1315
"protocol.d.ts",

0 commit comments

Comments
 (0)