Skip to content

Commit 2a11222

Browse files
DanielRosenwasserDanielRosenwasser
committed
'may not' -> 'cannot'
1 parent 75a1a8a commit 2a11222

5 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎src/compiler/checker.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7213,7 +7213,7 @@ module ts {
72137213
}
72147214
}
72157215
if (node.questionToken && isBindingPattern(node.name) && func.body) {
7216-
error(node, Diagnostics.A_binding_pattern_parameter_may_not_be_optional_in_an_implementation_signature);
7216+
error(node, Diagnostics.A_binding_pattern_parameter_cannot_be_optional_in_an_implementation_signature);
72177217
}
72187218
if (node.dotDotDotToken) {
72197219
if (!isArrayType(getTypeOfSymbol(node.symbol))) {

‎src/compiler/diagnosticInformationMap.generated.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ module ts {
297297
Type_0_has_no_property_1: { code: 2460, category: DiagnosticCategory.Error, key: "Type '{0}' has no property '{1}'." },
298298
Type_0_is_not_an_array_type: { code: 2461, category: DiagnosticCategory.Error, key: "Type '{0}' is not an array type." },
299299
A_rest_element_must_be_last_in_an_array_destructuring_pattern: { code: 2462, category: DiagnosticCategory.Error, key: "A rest element must be last in an array destructuring pattern" },
300-
A_binding_pattern_parameter_may_not_be_optional_in_an_implementation_signature: { code: 2463, category: DiagnosticCategory.Error, key: "A binding pattern parameter may not be optional in an implementation signature." },
300+
A_binding_pattern_parameter_cannot_be_optional_in_an_implementation_signature: { code: 2463, category: DiagnosticCategory.Error, key: "A binding pattern parameter cannot be optional in an implementation signature." },
301301
Import_declaration_0_is_using_private_name_1: { code: 4000, category: DiagnosticCategory.Error, key: "Import declaration '{0}' is using private name '{1}'." },
302302
Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: { code: 4002, category: DiagnosticCategory.Error, key: "Type parameter '{0}' of exported class has or is using private name '{1}'." },
303303
Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: { code: 4004, category: DiagnosticCategory.Error, key: "Type parameter '{0}' of exported interface has or is using private name '{1}'." },

‎src/compiler/diagnosticMessages.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1282,7 +1282,7 @@
12821282
"category": "Error",
12831283
"code": 2462
12841284
},
1285-
"A binding pattern parameter may not be optional in an implementation signature.": {
1285+
"A binding pattern parameter cannot be optional in an implementation signature.": {
12861286
"category": "Error",
12871287
"code": 2463
12881288
},

‎tests/baselines/reference/optionalBindingParameters1.errors.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
tests/cases/conformance/es6/destructuring/optionalBindingParameters1.ts(2,14): error TS2463: A binding pattern parameter may not be optional in an implementation signature.
1+
tests/cases/conformance/es6/destructuring/optionalBindingParameters1.ts(2,14): error TS2463: A binding pattern parameter cannot be optional in an implementation signature.
22
tests/cases/conformance/es6/destructuring/optionalBindingParameters1.ts(8,5): error TS2345: Argument of type '[boolean, number, string]' is not assignable to parameter of type '[string, number, boolean]'.
33

44

55
==== tests/cases/conformance/es6/destructuring/optionalBindingParameters1.ts (2 errors) ====
66

77
function foo([x,y,z]?: [string, number, boolean]) {
88
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
9-
!!! error TS2463: A binding pattern parameter may not be optional in an implementation signature.
9+
!!! error TS2463: A binding pattern parameter cannot be optional in an implementation signature.
1010

1111
}
1212

‎tests/baselines/reference/optionalBindingParameters2.errors.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
tests/cases/conformance/es6/destructuring/optionalBindingParameters2.ts(2,14): error TS2463: A binding pattern parameter may not be optional in an implementation signature.
1+
tests/cases/conformance/es6/destructuring/optionalBindingParameters2.ts(2,14): error TS2463: A binding pattern parameter cannot be optional in an implementation signature.
22
tests/cases/conformance/es6/destructuring/optionalBindingParameters2.ts(8,5): error TS2345: Argument of type '{ x: boolean; y: number; z: string; }' is not assignable to parameter of type '{ x: string; y: number; z: boolean; }'.
33
Types of property 'x' are incompatible.
44
Type 'boolean' is not assignable to type 'string'.
@@ -8,7 +8,7 @@ tests/cases/conformance/es6/destructuring/optionalBindingParameters2.ts(8,5): er
88

99
function foo({ x, y, z }?: { x: string; y: number; z: boolean }) {
1010
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11-
!!! error TS2463: A binding pattern parameter may not be optional in an implementation signature.
11+
!!! error TS2463: A binding pattern parameter cannot be optional in an implementation signature.
1212

1313
}
1414

0 commit comments

Comments
 (0)