Fix build/lint due to differences in master and LKG (microsoft#32450)

andrewbranch · web-flow · commit 246610957772 · 2019-07-17T13:07:10.000-07:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -411,7 +411,11 @@ namespace ts {
                     }
                 );
                 if (emitOnlyDtsFiles && declarationTransform.transformed[0].kind === SyntaxKind.SourceFile) {
-                    const sourceFile = declarationTransform.transformed[0] as SourceFile;
+                    // Improved narrowing in master/3.6 makes this cast unnecessary, triggering a lint rule.
+                    // But at the same time, the LKG (3.5) necessitates it because it doesn’t narrow.
+                    // Once the LKG is updated to 3.6, this comment, the cast to `SourceFile`, and the
+                    // tslint directive can be all be removed.
+                    const sourceFile = declarationTransform.transformed[0] as SourceFile; // tslint:disable-line
                     exportedModulesFromDeclarationEmit = sourceFile.exportedModulesFromDeclarationEmit;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -411,7 +411,11 @@ namespace ts {`
`411`	`411`	`}`
`412`	`412`	`);`
`413`	`413`	`if (emitOnlyDtsFiles && declarationTransform.transformed[0].kind === SyntaxKind.SourceFile) {`
`414`		`- const sourceFile = declarationTransform.transformed[0] as SourceFile;`
	`414`	`+ // Improved narrowing in master/3.6 makes this cast unnecessary, triggering a lint rule.`
	`415`	`+ // But at the same time, the LKG (3.5) necessitates it because it doesn’t narrow.`
	`416`	+ // Once the LKG is updated to 3.6, this comment, the cast to `SourceFile`, and the
	`417`	`+ // tslint directive can be all be removed.`
	`418`	`+ const sourceFile = declarationTransform.transformed[0] as SourceFile; // tslint:disable-line`
`415`	`419`	`exportedModulesFromDeclarationEmit = sourceFile.exportedModulesFromDeclarationEmit;`
`416`	`420`	`}`
`417`	`421`	`}`