better condition for file include exhaustiveness check

ajafff · ajafff · commit 239a7b9a4f2c · 2018-09-04T13:35:57.000+02:00
As `files` always contains declaration files of external libraries, lib files and declaration files from typeRoots, the previous condition evaluated to false for probably all projects out there.
This changes the condition to compare array length after filtering out all declaration files.
That avoids unnecessary work of path normalization in the common case where everything is ok.
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -2432,12 +2432,14 @@ namespace ts {
             }
 
             // List of collected files is complete; validate exhautiveness if this is a project with a file list
-            if (options.composite && rootNames.length < files.length) {
-                const normalizedRootNames = rootNames.map(r => normalizePath(r).toLowerCase());
-                const sourceFiles = files.filter(f => !f.isDeclarationFile).map(f => normalizePath(f.path).toLowerCase());
-                for (const file of sourceFiles) {
-                    if (normalizedRootNames.every(r => r !== file)) {
-                        programDiagnostics.add(createCompilerDiagnostic(Diagnostics.File_0_is_not_in_project_file_list_Projects_must_list_all_files_or_use_an_include_pattern, file));
+            if (options.composite) {
+                const sourceFiles = files.filter(f => !f.isDeclarationFile);
+                if (rootNames.length < sourceFiles.length) {
+                    const normalizedRootNames = rootNames.map(r => normalizePath(r).toLowerCase());
+                    for (const file of sourceFiles.map(f => normalizePath(f.path).toLowerCase())) {
+                        if (normalizedRootNames.indexOf(file) === -1) {
+                            programDiagnostics.add(createCompilerDiagnostic(Diagnostics.File_0_is_not_in_project_file_list_Projects_must_list_all_files_or_use_an_include_pattern, file));
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -2432,12 +2432,14 @@ namespace ts {`
`2432`	`2432`	`}`
`2433`	`2433`
`2434`	`2434`	`// List of collected files is complete; validate exhautiveness if this is a project with a file list`
`2435`		`- if (options.composite && rootNames.length < files.length) {`
`2436`		`- const normalizedRootNames = rootNames.map(r => normalizePath(r).toLowerCase());`
`2437`		`- const sourceFiles = files.filter(f => !f.isDeclarationFile).map(f => normalizePath(f.path).toLowerCase());`
`2438`		`- for (const file of sourceFiles) {`
`2439`		`- if (normalizedRootNames.every(r => r !== file)) {`
`2440`		`- programDiagnostics.add(createCompilerDiagnostic(Diagnostics.File_0_is_not_in_project_file_list_Projects_must_list_all_files_or_use_an_include_pattern, file));`
	`2435`	`+ if (options.composite) {`
	`2436`	`+ const sourceFiles = files.filter(f => !f.isDeclarationFile);`
	`2437`	`+ if (rootNames.length < sourceFiles.length) {`
	`2438`	`+ const normalizedRootNames = rootNames.map(r => normalizePath(r).toLowerCase());`
	`2439`	`+ for (const file of sourceFiles.map(f => normalizePath(f.path).toLowerCase())) {`
	`2440`	`+ if (normalizedRootNames.indexOf(file) === -1) {`
	`2441`	`+ programDiagnostics.add(createCompilerDiagnostic(Diagnostics.File_0_is_not_in_project_file_list_Projects_must_list_all_files_or_use_an_include_pattern, file));`
	`2442`	`+ }`
`2441`	`2443`	`}`
`2442`	`2444`	`}`
`2443`	`2445`	`}`