Missing files are versions are stored as number

sheetalkamat · sheetalkamat · commit 22c0444814f7 · 2018-02-06T13:48:09.000-08:00
diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -420,8 +420,7 @@ namespace ts {
         }
     }
 
-    const intialVersion = 1;
-    const intialVersionString = "1";
+    const initialVersion = 1;
 
     /**
      * Creates the watch from the host for root files and compiler options
@@ -437,7 +436,7 @@ namespace ts {
             sourceFile: SourceFile;
             fileWatcher: FileWatcher;
         }
-        type FileMissingOnHost = string;
+        type FileMissingOnHost = number;
         interface FilePresenceUnknownOnHost {
             version: number;
         }
@@ -637,7 +636,7 @@ namespace ts {
         }
 
         function isFileMissingOnHost(hostSourceFile: HostFileInfo): hostSourceFile is FileMissingOnHost {
-            return isString(hostSourceFile);
+            return typeof hostSourceFile === "number";
         }
 
         function isFilePresentOnHost(hostSourceFile: FileMayBePresentOnHost): hostSourceFile is FilePresentOnHost {
@@ -683,17 +682,17 @@ namespace ts {
                         if (isFilePresentOnHost(hostSourceFile)) {
                             hostSourceFile.fileWatcher.close();
                         }
-                        sourceFilesCache.set(path, hostSourceFile.version.toString());
+                        sourceFilesCache.set(path, hostSourceFile.version);
                     }
                 }
                 else {
                     if (sourceFile) {
-                        sourceFile.version = intialVersionString;
+                        sourceFile.version = initialVersion.toString();
                         const fileWatcher = watchFilePath(host, fileName, onSourceFileChange, path, writeLog);
-                        sourceFilesCache.set(path, { sourceFile, version: intialVersion, fileWatcher });
+                        sourceFilesCache.set(path, { sourceFile, version: initialVersion, fileWatcher });
                     }
                     else {
-                        sourceFilesCache.set(path, intialVersionString);
+                        sourceFilesCache.set(path, initialVersion);
                     }
                 }
                 return sourceFile;

Original file line number	Diff line number	Diff line change
`@@ -420,8 +420,7 @@ namespace ts {`
`420`	`420`	`}`
`421`	`421`	`}`
`422`	`422`
`423`		`- const intialVersion = 1;`
`424`		`- const intialVersionString = "1";`
	`423`	`+ const initialVersion = 1;`
`425`	`424`
`426`	`425`	`/**`
`427`	`426`	`* Creates the watch from the host for root files and compiler options`
`@@ -437,7 +436,7 @@ namespace ts {`
`437`	`436`	`sourceFile: SourceFile;`
`438`	`437`	`fileWatcher: FileWatcher;`
`439`	`438`	`}`
`440`		`- type FileMissingOnHost = string;`
	`439`	`+ type FileMissingOnHost = number;`
`441`	`440`	`interface FilePresenceUnknownOnHost {`
`442`	`441`	`version: number;`
`443`	`442`	`}`
`@@ -637,7 +636,7 @@ namespace ts {`
`637`	`636`	`}`
`638`	`637`
`639`	`638`	`function isFileMissingOnHost(hostSourceFile: HostFileInfo): hostSourceFile is FileMissingOnHost {`
`640`		`- return isString(hostSourceFile);`
	`639`	`+ return typeof hostSourceFile === "number";`
`641`	`640`	`}`
`642`	`641`
`643`	`642`	`function isFilePresentOnHost(hostSourceFile: FileMayBePresentOnHost): hostSourceFile is FilePresentOnHost {`
`@@ -683,17 +682,17 @@ namespace ts {`
`683`	`682`	`if (isFilePresentOnHost(hostSourceFile)) {`
`684`	`683`	`hostSourceFile.fileWatcher.close();`
`685`	`684`	`}`
`686`		`- sourceFilesCache.set(path, hostSourceFile.version.toString());`
	`685`	`+ sourceFilesCache.set(path, hostSourceFile.version);`
`687`	`686`	`}`
`688`	`687`	`}`
`689`	`688`	`else {`
`690`	`689`	`if (sourceFile) {`
`691`		`- sourceFile.version = intialVersionString;`
	`690`	`+ sourceFile.version = initialVersion.toString();`
`692`	`691`	`const fileWatcher = watchFilePath(host, fileName, onSourceFileChange, path, writeLog);`
`693`		`- sourceFilesCache.set(path, { sourceFile, version: intialVersion, fileWatcher });`
	`692`	`+ sourceFilesCache.set(path, { sourceFile, version: initialVersion, fileWatcher });`
`694`	`693`	`}`
`695`	`694`	`else {`
`696`		`- sourceFilesCache.set(path, intialVersionString);`
	`695`	`+ sourceFilesCache.set(path, initialVersion);`
`697`	`696`	`}`
`698`	`697`	`}`
`699`	`698`	`return sourceFile;`