Port changes from microsoft#22172, provide a callback to fs.close (microsoft#22405)

mhegazy · web-flow · commit 1fc3aebc20a1 · 2018-03-09T08:30:09.000-08:00
diff --git a/src/server/server.ts b/src/server/server.ts
@@ -128,7 +128,7 @@ namespace ts.server {
 
     const fs: {
         openSync(path: string, options: string): number;
-        close(fd: number): void;
+        close(fd: number, callback: (err: NodeJS.ErrnoException) => void): void;
         writeSync(fd: number, buffer: Buffer, offset: number, length: number, position?: number): number;
         writeSync(fd: number, data: any, position?: number, enconding?: string): number;
         statSync(path: string): Stats;
@@ -167,7 +167,7 @@ namespace ts.server {
 
         close() {
             if (this.fd >= 0) {
-                fs.close(this.fd);
+                fs.close(this.fd, noop);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ namespace ts.server {`
`128`	`128`
`129`	`129`	`const fs: {`
`130`	`130`	`openSync(path: string, options: string): number;`
`131`		`- close(fd: number): void;`
	`131`	`+ close(fd: number, callback: (err: NodeJS.ErrnoException) => void): void;`
`132`	`132`	`writeSync(fd: number, buffer: Buffer, offset: number, length: number, position?: number): number;`
`133`	`133`	`writeSync(fd: number, data: any, position?: number, enconding?: string): number;`
`134`	`134`	`statSync(path: string): Stats;`
`@@ -167,7 +167,7 @@ namespace ts.server {`
`167`	`167`
`168`	`168`	`close() {`
`169`	`169`	`if (this.fd >= 0) {`
`170`		`- fs.close(this.fd);`
	`170`	`+ fs.close(this.fd, noop);`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`