Merge pull request microsoft#16225 from Microsoft/sandersn/weakType

ahejlsberg · web-flow · commit 1f606bd56d86 · 2017-06-02T13:53:16.000-07:00
No weak type checks with comparable relation
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -8816,7 +8816,8 @@ namespace ts {
                     }
                 }
 
-                if (!(source.flags & TypeFlags.UnionOrIntersection) &&
+                if (relation !== comparableRelation &&
+                    !(source.flags & TypeFlags.UnionOrIntersection) &&
                     !(target.flags & TypeFlags.Union) &&
                     !isIntersectionConstituent &&
                     source !== globalObjectType &&

Original file line number	Diff line number	Diff line change
`@@ -8816,7 +8816,8 @@ namespace ts {`
`8816`	`8816`	`}`
`8817`	`8817`	`}`
`8818`	`8818`
`8819`		`- if (!(source.flags & TypeFlags.UnionOrIntersection) &&`
	`8819`	`+ if (relation !== comparableRelation &&`
	`8820`	`+ !(source.flags & TypeFlags.UnionOrIntersection) &&`
`8820`	`8821`	`!(target.flags & TypeFlags.Union) &&`
`8821`	`8822`	`!isIntersectionConstituent &&`
`8822`	`8823`	`source !== globalObjectType &&`