Fix microsoft#4808: Follow target symbols

mhegazy · mhegazy · commit 1af576b0641e · 2016-05-04T12:06:51.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -16795,7 +16795,11 @@ namespace ts {
                 return symbols;
             }
             else if (symbol.flags & SymbolFlags.Transient) {
-                const target = getSymbolLinks(symbol).target;
+                let target: Symbol;
+                let next: Symbol = symbol;
+                while (next = getSymbolLinks(next).target) {
+                   target = next;
+                }
                 if (target) {
                     return [target];
                 }
diff --git a/tests/cases/fourslash/findAllRefsForObjectLiteralProperties.ts b/tests/cases/fourslash/findAllRefsForObjectLiteralProperties.ts
@@ -0,0 +1,20 @@
+/// <reference path='fourslash.ts'/>
+
+////var x = {
+////    [|property|]: {}
+////};
+////
+////x.[|property|];
+////
+////let {[|property|]: pVar} = x;
+
+
+let ranges = test.ranges();
+for (let range of ranges) {
+    goTo.position(range.start);
+
+    verify.referencesCountIs(ranges.length);
+    for (let expectedReference of ranges) {
+        verify.referencesAtPositionContains(expectedReference);
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -16795,7 +16795,11 @@ namespace ts {`
`16795`	`16795`	`return symbols;`
`16796`	`16796`	`}`
`16797`	`16797`	`else if (symbol.flags & SymbolFlags.Transient) {`
`16798`		`- const target = getSymbolLinks(symbol).target;`
	`16798`	`+ let target: Symbol;`
	`16799`	`+ let next: Symbol = symbol;`
	`16800`	`+ while (next = getSymbolLinks(next).target) {`
	`16801`	`+ target = next;`
	`16802`	`+ }`
`16799`	`16803`	`if (target) {`
`16800`	`16804`	`return [target];`
`16801`	`16805`	`}`