Handle dts change as well as signature update when exported module affects dts but not js file

sheetalkamat · sheetalkamat · commit 17d2c8bcfb92 · 2019-04-16T13:27:51.000-07:00
diff --git a/src/compiler/builder.ts b/src/compiler/builder.ts
@@ -340,7 +340,7 @@ namespace ts {
                         // Set the next affected file as seen and remove the cached semantic diagnostics
                         state.affectedFilesIndex = affectedFilesIndex;
                         cleanSemanticDiagnosticsOfAffectedFile(state, affectedFile);
-                        handleDtsMayChangeOfAffectedFile(state, affectedFile)
+                        handleDtsMayChangeOfAffectedFile(state, affectedFile, cancellationToken, computeHash);
                         return affectedFile;
                     }
                     seenAffectedFiles.set(affectedFile.path, true);
@@ -451,11 +451,7 @@ namespace ts {
      *  Add files, that are referencing modules that export entities from affected file as pending emit since dts may change
      *  Similar to cleanSemanticDiagnosticsOfAffectedFile
      */
-    function handleDtsMayChangeOfAffectedFile(state: BuilderProgramState, affectedFile: SourceFile) {
-        // If not dts emit, nothing more to do
-        if (!getEmitDeclarations(state.compilerOptions)) {
-            return;
-        }
+    function handleDtsMayChangeOfAffectedFile(state: BuilderProgramState, affectedFile: SourceFile, cancellationToken: CancellationToken | undefined, computeHash: BuilderState.ComputeHash) {
 
         // If affected files is everything except default librarry, then nothing more to do
         if (state.allFilesExcludingDefaultLibraryFile === state.affectedFiles) {
@@ -468,10 +464,26 @@ namespace ts {
             return;
         }
 
-        forEachReferencingModulesOfExportOfAffectedFile(state, affectedFile, (state, filePath) => {
-            addToAffectedFilesPendingEmit(state, [filePath]);
-            return false;
-        });
+        forEachReferencingModulesOfExportOfAffectedFile(state, affectedFile, (state, path) => handleDtsMayChangeOf(state, path, cancellationToken, computeHash));
+    }
+
+    /**
+     * Handle the dts may change, so they need to be added to pending emit if dts emit is enabled,
+     * Also we need to make sure signature is updated for these files
+     */
+    function handleDtsMayChangeOf(state: BuilderProgramState, path: Path, cancellationToken: CancellationToken | undefined, computeHash: BuilderState.ComputeHash) {
+        if (!state.changedFilesSet.has(path)) {
+            const program = Debug.assertDefined(state.program);
+            const sourceFile = program.getSourceFileByPath(path);
+            if (sourceFile) {
+                BuilderState.updateShapeSignature(state, program, sourceFile, Debug.assertDefined(state.currentAffectedFilesSignatures), cancellationToken, computeHash, state.currentAffectedFilesExportedModulesMap);
+                // If not dts emit, nothing more to do
+                if (getEmitDeclarations(state.compilerOptions)) {
+                    addToAffectedFilesPendingEmit(state, [path]);
+                }
+            }
+        }
+        return false;
     }
 
     /**
diff --git a/src/compiler/builderState.ts b/src/compiler/builderState.ts
@@ -321,7 +321,7 @@ namespace ts.BuilderState {
     /**
      * Returns if the shape of the signature has changed since last emit
      */
-    function updateShapeSignature(state: Readonly<BuilderState>, programOfThisState: Program, sourceFile: SourceFile, cacheToUpdateSignature: Map<string>, cancellationToken: CancellationToken | undefined, computeHash: ComputeHash, exportedModulesMapCache?: ComputingExportedModulesMap) {
+    export function updateShapeSignature(state: Readonly<BuilderState>, programOfThisState: Program, sourceFile: SourceFile, cacheToUpdateSignature: Map<string>, cancellationToken: CancellationToken | undefined, computeHash: ComputeHash, exportedModulesMapCache?: ComputingExportedModulesMap) {
         Debug.assert(!!sourceFile);
         Debug.assert(!exportedModulesMapCache || !!state.exportedModulesMap, "Compute visible to outside map only if visibleToOutsideReferencedMap present in the state");
 
diff --git a/tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/incremental-declaration-changes/inferred-type-from-transitive-module.js b/tests/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/incremental-declaration-changes/inferred-type-from-transitive-module.js
@@ -52,7 +52,7 @@ export declare const lazyBar: LazyAction<() => void, typeof import("./lazyIndex"
       },
       "/src/index.ts": {
         "version": "-11602502901",
-        "signature": "18468008756"
+        "signature": "6256067474"
       }
     },
     "options": {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export declare const lazyBar: LazyAction<() => void, typeof import("./lazyIndex"`
`52`	`52`	`},`
`53`	`53`	`"/src/index.ts": {`
`54`	`54`	`"version": "-11602502901",`
`55`		`- "signature": "18468008756"`
	`55`	`+ "signature": "6256067474"`
`56`	`56`	`}`
`57`	`57`	`},`
`58`	`58`	`"options": {`