Fix microsoft#9402: Do not report unused identifier errors for catch variables

mhegazy · mhegazy · commit 17a428c21f68 · 2016-06-28T16:04:52.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -15563,7 +15563,6 @@ namespace ts {
                 }
 
                 checkBlock(catchClause.block);
-                checkUnusedIdentifiers(catchClause);
             }
 
             if (node.finallyBlock) {
diff --git a/tests/baselines/reference/unusedParameterInCatchClause.errors.txt b/tests/baselines/reference/unusedParameterInCatchClause.errors.txt
diff --git a/tests/baselines/reference/unusedParameterInCatchClause.symbols b/tests/baselines/reference/unusedParameterInCatchClause.symbols
@@ -0,0 +1,8 @@
+=== tests/cases/compiler/unusedParameterInCatchClause.ts ===
+
+function f1() {
+>f1 : Symbol(f1, Decl(unusedParameterInCatchClause.ts, 0, 0))
+
+    try {} catch(ex){}
+>ex : Symbol(ex, Decl(unusedParameterInCatchClause.ts, 2, 17))
+}
diff --git a/tests/baselines/reference/unusedParameterInCatchClause.types b/tests/baselines/reference/unusedParameterInCatchClause.types
@@ -0,0 +1,8 @@
+=== tests/cases/compiler/unusedParameterInCatchClause.ts ===
+
+function f1() {
+>f1 : () => void
+
+    try {} catch(ex){}
+>ex : any
+}

Original file line number	Diff line number	Diff line change
`@@ -15563,7 +15563,6 @@ namespace ts {`
`15563`	`15563`	`}`
`15564`	`15564`
`15565`	`15565`	`checkBlock(catchClause.block);`
`15566`		`- checkUnusedIdentifiers(catchClause);`
`15567`	`15566`	`}`
`15568`	`15567`
`15569`	`15568`	`if (node.finallyBlock) {`