Correct project root path passed to Typings Installer

amcasey · amcasey · commit 1793652373c4 · 2017-11-20T18:56:27.000-08:00
`createInstallTypingsRequest` has its own logic for extracting the
project root path from the project name and it disagrees with the
versions in the project flavors.  In particular, it only drops the last
component of the name if it exists.  For folder projects and JS-only
contexts, this will not be the case, but the last entry should still be
dropped.

TL;DR: stop creating filewatchers for
"c:/foo/foo.csproj*jscontent/node_modules"
diff --git a/src/server/utilities.ts b/src/server/utilities.ts
@@ -43,7 +43,7 @@ namespace ts.server {
                 return <Path>"";
             case ProjectKind.External:
                 const projectName = normalizeSlashes(project.getProjectName());
-                return project.projectService.host.fileExists(projectName) ? <Path>getDirectoryPath(projectName) : <Path>projectName;
+                return <Path>getDirectoryPath(projectName);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ namespace ts.server {`
`43`	`43`	`return <Path>"";`
`44`	`44`	`case ProjectKind.External:`
`45`	`45`	`const projectName = normalizeSlashes(project.getProjectName());`
`46`		`- return project.projectService.host.fileExists(projectName) ? <Path>getDirectoryPath(projectName) : <Path>projectName;`
	`46`	`+ return <Path>getDirectoryPath(projectName);`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`