Add type alias for filewatching callbacks

Zhengbo Li · Zhengbo Li · commit 178b2dabfe7f · 2015-12-21T17:02:00.000-08:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -612,7 +612,9 @@ namespace ts {
         return path.substr(0, rootLength) + normalized.join(directorySeparator);
     }
 
-    export function getDirectoryPath(path: string) {
+    export function getDirectoryPath(path: Path): Path;
+    export function getDirectoryPath(path: string): string;
+    export function getDirectoryPath(path: string): any {
         return path.substr(0, Math.max(getRootLength(path), path.lastIndexOf(directorySeparator)));
     }
 
diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts
@@ -1,15 +1,18 @@
 /// <reference path="core.ts"/>
 
 namespace ts {
+    export type CallbackForWatchedFile = (path: string, removed?: boolean) => void;
+    export type CallbackForWatchedDirectory = (path: string) => void;
+
     export interface System {
         args: string[];
         newLine: string;
         useCaseSensitiveFileNames: boolean;
         write(s: string): void;
         readFile(path: string, encoding?: string): string;
         writeFile(path: string, data: string, writeByteOrderMark?: boolean): void;
-        watchFile?(path: string, callback: (path: string, removed?: boolean) => void): FileWatcher;
-        watchDirectory?(path: string, callback: (path: string) => void, recursive?: boolean): FileWatcher;
+        watchFile?(path: string, callback: CallbackForWatchedFile): FileWatcher;
+        watchDirectory?(path: string, callback: CallbackForWatchedDirectory, recursive?: boolean): FileWatcher;
         resolvePath(path: string): string;
         fileExists(path: string): boolean;
         directoryExists(path: string): boolean;
@@ -23,7 +26,7 @@ namespace ts {
 
     interface WatchedFile {
         fileName: string;
-        callback: (fileName: string, removed?: boolean) => void;
+        callback: CallbackForWatchedFile;
         mtime?: Date;
     }
 
@@ -62,8 +65,8 @@ namespace ts {
         readFile(path: string): string;
         writeFile(path: string, contents: string): void;
         readDirectory(path: string, extension?: string, exclude?: string[]): string[];
-        watchFile?(path: string, callback: (path: string, removed?: boolean) => void): FileWatcher;
-        watchDirectory?(path: string, callback: (path: string) => void, recursive?: boolean): FileWatcher;
+        watchFile?(path: string, callback: CallbackForWatchedFile): FileWatcher;
+        watchDirectory?(path: string, callback: CallbackForWatchedDirectory, recursive?: boolean): FileWatcher;
     };
 
     export var sys: System = (function () {
@@ -271,7 +274,7 @@ namespace ts {
                     }, interval);
                 }
 
-                function addFile(fileName: string, callback: (fileName: string, removed?: boolean) => void): WatchedFile {
+                function addFile(fileName: string, callback: CallbackForWatchedFile): WatchedFile {
                     const file: WatchedFile = {
                         fileName,
                         callback,
@@ -298,16 +301,18 @@ namespace ts {
                 };
             }
 
+            
+
             function createWatchedFileSet() {
                 const watchedDirectories = createFileMap<FileWatcher>();
-                const watchedFiles = createFileMap<(fileName: string, removed?: boolean) => void>();
+                const watchedFiles = createFileMap<CallbackForWatchedFile>();
                 const currentDirectory = process.cwd();
 
                 return { addFile, removeFile };
 
-                function addFile(fileName: string, callback: (fileName: string, removed?: boolean) => void): WatchedFile {
+                function addFile(fileName: string, callback: CallbackForWatchedFile): WatchedFile {
                     const path = toPath(fileName, currentDirectory, getCanonicalPath);
-                    const parentDirPath = toPath(ts.getDirectoryPath(fileName), currentDirectory, getCanonicalPath);
+                    const parentDirPath = getDirectoryPath(path);
 
                     if (!watchedDirectories.contains(parentDirPath)) {
                         watchedDirectories.set(parentDirPath, _fs.watch(
@@ -323,7 +328,7 @@ namespace ts {
                     const path = toPath(file.fileName, currentDirectory, getCanonicalPath);
                     watchedFiles.remove(path);
 
-                    const parentDirPath = toPath(ts.getDirectoryPath(path), currentDirectory, getCanonicalPath);
+                    const parentDirPath = getDirectoryPath(path);
                     if (watchedDirectories.contains(parentDirPath)) {
                         let hasWatchedChildren = false;
                         watchedFiles.forEachValue((key, _) => {
@@ -474,9 +479,10 @@ namespace ts {
                 watchDirectory: (path, callback, recursive) => {
                     // Node 4.0 `fs.watch` function supports the "recursive" option on both OSX and Windows
                     // (ref: https://github.com/nodejs/node/pull/2649 and https://github.com/Microsoft/TypeScript/issues/4643)
+                    const options = isNode4OrLater() ? { persistent: true } : { persistent: true, recursive: !!recursive };
                     return _fs.watch(
                         path,
-                        { persistent: true, recursive: !!recursive },
+                        options,
                         (eventName: string, relativeFileName: string) => {
                             // In watchDirectory we only care about adding and removing files (when event name is
                             // "rename"); changes made within files are handled by corresponding fileWatchers (when

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,9 @@ namespace ts {`
`612`	`612`	`return path.substr(0, rootLength) + normalized.join(directorySeparator);`
`613`	`613`	`}`
`614`	`614`
`615`		`- export function getDirectoryPath(path: string) {`
	`615`	`+ export function getDirectoryPath(path: Path): Path;`
	`616`	`+ export function getDirectoryPath(path: string): string;`
	`617`	`+ export function getDirectoryPath(path: string): any {`
`616`	`618`	`return path.substr(0, Math.max(getRootLength(path), path.lastIndexOf(directorySeparator)));`
`617`	`619`	`}`
`618`	`620`