Do not report error on unused removed property from object spread

sheetalkamat · sheetalkamat · commit 14cce292506b · 2016-12-21T11:46:09.000-08:00
Fixes microsoft#13076
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -16891,7 +16891,7 @@ namespace ts {
                     if (!local.isReferenced && !local.exportSymbol) {
                         for (const declaration of local.declarations) {
                             if (!isAmbientModule(declaration)) {
-                                error(declaration.name, Diagnostics._0_is_declared_but_never_used, local.name);
+                                errorUnusedLocal(declaration.name, local.name);
                             }
                         }
                     }
diff --git a/tests/baselines/reference/unusedLocalsAndObjectSpread2.errors.txt b/tests/baselines/reference/unusedLocalsAndObjectSpread2.errors.txt
@@ -1,20 +1,14 @@
-tests/cases/compiler/unusedLocalsAndObjectSpread2.ts(4,5): error TS6133: 'children' is declared but never used.
-tests/cases/compiler/unusedLocalsAndObjectSpread2.ts(5,13): error TS6133: '_a' is declared but never used.
 tests/cases/compiler/unusedLocalsAndObjectSpread2.ts(6,6): error TS6133: 'rest' is declared but never used.
 tests/cases/compiler/unusedLocalsAndObjectSpread2.ts(9,10): error TS6133: 'foo' is declared but never used.
 tests/cases/compiler/unusedLocalsAndObjectSpread2.ts(13,8): error TS6133: 'rest' is declared but never used.
 
 
-==== tests/cases/compiler/unusedLocalsAndObjectSpread2.ts (5 errors) ====
+==== tests/cases/compiler/unusedLocalsAndObjectSpread2.ts (3 errors) ====
     
     declare let props: any;
     const {
         children, // here!
-        ~~~~~~~~
-!!! error TS6133: 'children' is declared but never used.
         active: _a, // here!
-                ~~
-!!! error TS6133: '_a' is declared but never used.
       ...rest,
          ~~~~
 !!! error TS6133: 'rest' is declared but never used.

Original file line number	Diff line number	Diff line change
`@@ -16891,7 +16891,7 @@ namespace ts {`
`16891`	`16891`	`if (!local.isReferenced && !local.exportSymbol) {`
`16892`	`16892`	`for (const declaration of local.declarations) {`
`16893`	`16893`	`if (!isAmbientModule(declaration)) {`
`16894`		`- error(declaration.name, Diagnostics._0_is_declared_but_never_used, local.name);`
	`16894`	`+ errorUnusedLocal(declaration.name, local.name);`
`16895`	`16895`	`}`
`16896`	`16896`	`}`
`16897`	`16897`	`}`