Use 'append' helper more (microsoft#21125)

Andy · web-flow · commit 102368332eb4 · 2018-01-10T11:31:13.000-08:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -6603,10 +6603,7 @@ namespace ts {
                         const start = scanner.getStartPos();
                         let children: JSDocParameterTag[];
                         while (child = tryParse(() => parseChildParameterOrPropertyTag(PropertyLikeParse.Parameter, name))) {
-                            if (!children) {
-                                children = [];
-                            }
-                            children.push(child);
+                            children = append(children, child);
                         }
                         if (children) {
                             jsdocTypeLiteral = <JSDocTypeLiteral>createNode(SyntaxKind.JSDocTypeLiteral, start);
@@ -6723,10 +6720,7 @@ namespace ts {
                                 }
                             }
                             else {
-                                if (!jsdocTypeLiteral.jsDocPropertyTags) {
-                                    jsdocTypeLiteral.jsDocPropertyTags = [] as MutableNodeArray<JSDocPropertyTag>;
-                                }
-                                (jsdocTypeLiteral.jsDocPropertyTags as MutableNodeArray<JSDocPropertyTag>).push(child);
+                                jsdocTypeLiteral.jsDocPropertyTags = append(jsdocTypeLiteral.jsDocPropertyTags as MutableNodeArray<JSDocPropertyTag>, child);
                             }
                         }
                         if (jsdocTypeLiteral) {

Original file line number	Diff line number	Diff line change
`@@ -6603,10 +6603,7 @@ namespace ts {`
`6603`	`6603`	`const start = scanner.getStartPos();`
`6604`	`6604`	`let children: JSDocParameterTag[];`
`6605`	`6605`	`while (child = tryParse(() => parseChildParameterOrPropertyTag(PropertyLikeParse.Parameter, name))) {`
`6606`		`- if (!children) {`
`6607`		`- children = [];`
`6608`		`- }`
`6609`		`- children.push(child);`
	`6606`	`+ children = append(children, child);`
`6610`	`6607`	`}`
`6611`	`6608`	`if (children) {`
`6612`	`6609`	`jsdocTypeLiteral = <JSDocTypeLiteral>createNode(SyntaxKind.JSDocTypeLiteral, start);`
`@@ -6723,10 +6720,7 @@ namespace ts {`
`6723`	`6720`	`}`
`6724`	`6721`	`}`
`6725`	`6722`	`else {`
`6726`		`- if (!jsdocTypeLiteral.jsDocPropertyTags) {`
`6727`		`- jsdocTypeLiteral.jsDocPropertyTags = [] as MutableNodeArray<JSDocPropertyTag>;`
`6728`		`- }`
`6729`		`- (jsdocTypeLiteral.jsDocPropertyTags as MutableNodeArray<JSDocPropertyTag>).push(child);`
	`6723`	`+ jsdocTypeLiteral.jsDocPropertyTags = append(jsdocTypeLiteral.jsDocPropertyTags as MutableNodeArray<JSDocPropertyTag>, child);`
`6730`	`6724`	`}`
`6731`	`6725`	`}`
`6732`	`6726`	`if (jsdocTypeLiteral) {`