Fix the quick info on error types

sheetalkamat · sheetalkamat · commit 0dbd30308450 · 2014-09-30T17:14:58.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -1288,7 +1288,7 @@ module ts {
         }
 
         function writeTypeParameters(typeParameters: TypeParameter[], writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags, typeStack?: Type[]) {
-            if (typeParameters) {
+            if (typeParameters && typeParameters.length) {
                 writePunctuation(writer, SyntaxKind.LessThanToken);
                 for (var i = 0; i < typeParameters.length; i++) {
                     if (i > 0) {
diff --git a/tests/baselines/reference/dontShowCompilerGeneratedMembers.errors.txt b/tests/baselines/reference/dontShowCompilerGeneratedMembers.errors.txt
@@ -2,14 +2,14 @@ tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,5): error TS1098: Typ
 tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,6): error TS1005: '(' expected.
 tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,6): error TS1139: Type parameter declaration expected.
 tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(4,1): error TS1109: Expression expected.
-tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(1,5): error TS2322: Type 'number' is not assignable to type '{ <>(): any; x: number; }':
+tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(1,5): error TS2322: Type 'number' is not assignable to type '{ (): any; x: number; }':
   Property 'x' is missing in type 'Number'.
 
 
 ==== tests/cases/compiler/dontShowCompilerGeneratedMembers.ts (5 errors) ====
     var f: {
         ~
-!!! error TS2322: Type 'number' is not assignable to type '{ <>(): any; x: number; }':
+!!! error TS2322: Type 'number' is not assignable to type '{ (): any; x: number; }':
 !!! error TS2322:   Property 'x' is missing in type 'Number'.
         x: number;
         <-
diff --git a/tests/cases/fourslash/quickInfoOnErrorTypes1.ts b/tests/cases/fourslash/quickInfoOnErrorTypes1.ts
@@ -6,4 +6,4 @@
 ////};
 
 goTo.marker('A');
-verify.quickInfoIs('{ x: number; (): any; }', "", "f", "var");
+verify.quickInfoIs('(var) f: {\n    (): any;\n    x: number;\n}', "");

Original file line number	Diff line number	Diff line change
`@@ -1288,7 +1288,7 @@ module ts {`
`1288`	`1288`	`}`
`1289`	`1289`
`1290`	`1290`	`function writeTypeParameters(typeParameters: TypeParameter[], writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags, typeStack?: Type[]) {`
`1291`		`- if (typeParameters) {`
	`1291`	`+ if (typeParameters && typeParameters.length) {`
`1292`	`1292`	`writePunctuation(writer, SyntaxKind.LessThanToken);`
`1293`	`1293`	`for (var i = 0; i < typeParameters.length; i++) {`
`1294`	`1294`	`if (i > 0) {`