Debug.failBadSyntaxKind should always be defined and return 'never' (microsoft#22091)

Andy · web-flow · commit 0a2c160dd1b7 · 2018-03-27T13:35:48.000-07:00
diff --git a/src/compiler/visitor.ts b/src/compiler/visitor.ts
@@ -1546,11 +1546,11 @@ namespace ts {
     export namespace Debug {
         let isDebugInfoEnabled = false;
 
-        export const failBadSyntaxKind = shouldAssert(AssertionLevel.Normal)
-            ? (node: Node, message?: string): never => fail(
+        export function failBadSyntaxKind(node: Node, message?: string): never {
+            return fail(
                 `${message || "Unexpected node."}\r\nNode ${formatSyntaxKind(node.kind)} was unexpected.`,
-                failBadSyntaxKind)
-            : noop as () => never; // TODO: GH#22091
+                failBadSyntaxKind);
+        }
 
         export const assertEachNode = shouldAssert(AssertionLevel.Normal)
             ? (nodes: Node[], test: (node: Node) => boolean, message?: string): void => assert(
