Expose ProjectService to plugins (microsoft#23824)

Andy · web-flow · commit 05b250691f3e · 2018-05-07T12:38:38.000-07:00
Add refreshDiagnostics() method to Project
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -577,7 +577,8 @@ namespace ts.server {
             return this.pendingProjectUpdates.has(project.getProjectName());
         }
 
-        private sendProjectsUpdatedInBackgroundEvent() {
+        /* @internal */
+        sendProjectsUpdatedInBackgroundEvent() {
             if (!this.eventHandler) {
                 return;
             }
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -164,7 +164,7 @@ namespace ts.server {
             return hasOneOrMoreJsAndNoTsFiles(this);
         }
 
-        public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} {
+        public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} | undefined {
             const resolvedPath = normalizeSlashes(host.resolvePath(combinePaths(initialDir, "node_modules")));
             log(`Loading ${moduleName} from ${initialDir} (resolved to ${resolvedPath})`);
             const result = host.require(resolvedPath, moduleName);
@@ -1102,6 +1102,11 @@ namespace ts.server {
             }
         }
 
+        /** Starts a new check for diagnostics. Call this if some file has updated that would cause diagnostics to be changed. */
+        refreshDiagnostics() {
+            this.projectService.sendProjectsUpdatedInBackgroundEvent();
+        }
+
         private enableProxy(pluginModuleFactory: PluginModuleFactory, configEntry: PluginImport) {
             try {
                 if (typeof pluginModuleFactory !== "function") {
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -7748,7 +7748,7 @@ declare namespace ts.server {
         private readonly cancellationToken;
         isNonTsProject(): boolean;
         isJsOnlyProject(): boolean;
-        static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {};
+        static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} | undefined;
         isKnownTypesPackageName(name: string): boolean;
         installPackage(options: InstallPackageOptions): Promise<ApplyCodeActionCommandResult>;
         private readonly typingsCache;
@@ -7829,6 +7829,8 @@ declare namespace ts.server {
         protected removeRoot(info: ScriptInfo): void;
         protected enableGlobalPlugins(): void;
         protected enablePlugin(pluginConfigEntry: PluginImport, searchPaths: string[]): void;
+        /** Starts a new check for diagnostics. Call this if some file has updated that would cause diagnostics to be changed. */
+        refreshDiagnostics(): void;
         private enableProxy;
     }
     /**
@@ -8081,7 +8083,6 @@ declare namespace ts.server {
         updateTypingsForProject(response: SetTypings | InvalidateCachedTypings | PackageInstalledResponse): void;
         private delayEnsureProjectForOpenFiles;
         private delayUpdateProjectGraph;
-        private sendProjectsUpdatedInBackgroundEvent;
         private delayUpdateProjectGraphs;
         setCompilerOptionsForInferredProjects(projectCompilerOptions: protocol.ExternalProjectCompilerOptions, projectRootPath?: string): void;
         findProject(projectName: string): Project | undefined;

Original file line number	Diff line number	Diff line change
`@@ -577,7 +577,8 @@ namespace ts.server {`
`577`	`577`	`return this.pendingProjectUpdates.has(project.getProjectName());`
`578`	`578`	`}`
`579`	`579`
`580`		`- private sendProjectsUpdatedInBackgroundEvent() {`
	`580`	`+ /* @internal */`
	`581`	`+ sendProjectsUpdatedInBackgroundEvent() {`
`581`	`582`	`if (!this.eventHandler) {`
`582`	`583`	`return;`
`583`	`584`	`}`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ namespace ts.server {`
`164`	`164`	`return hasOneOrMoreJsAndNoTsFiles(this);`
`165`	`165`	`}`
`166`	`166`
`167`		`- public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} {`
	`167`	`+ public static resolveModule(moduleName: string, initialDir: string, host: ServerHost, log: (message: string) => void): {} \| undefined {`
`168`	`168`	`const resolvedPath = normalizeSlashes(host.resolvePath(combinePaths(initialDir, "node_modules")));`
`169`	`169`	log(`Loading ${moduleName} from ${initialDir} (resolved to ${resolvedPath})`);
`170`	`170`	`const result = host.require(resolvedPath, moduleName);`
`@@ -1102,6 +1102,11 @@ namespace ts.server {`
`1102`	`1102`	`}`
`1103`	`1103`	`}`
`1104`	`1104`
	`1105`	`+ /** Starts a new check for diagnostics. Call this if some file has updated that would cause diagnostics to be changed. */`
	`1106`	`+ refreshDiagnostics() {`
	`1107`	`+ this.projectService.sendProjectsUpdatedInBackgroundEvent();`
	`1108`	`+ }`
	`1109`	`+`
`1105`	`1110`	`private enableProxy(pluginModuleFactory: PluginModuleFactory, configEntry: PluginImport) {`
`1106`	`1111`	`try {`
`1107`	`1112`	`if (typeof pluginModuleFactory !== "function") {`