Skip to content

Commit 051da11

Browse files
author
Armando Aguirre
committed
Removed custom guard and added isArray
1 parent 16c3255 commit 051da11

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

src/harness/fourslash.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -641,16 +641,17 @@ namespace FourSlash {
641641
const defs = getDefs();
642642
let definitions: ts.DefinitionInfo[] | ReadonlyArray<ts.DefinitionInfo>;
643643
let testName: string;
644-
if (this.isDefinitionInfoAndBoundSpan(defs)) {
644+
645+
if (!defs || Array.isArray(defs)) {
646+
definitions = defs as ts.DefinitionInfo[] || [];
647+
testName = "goToDefinitions";
648+
}
649+
else {
645650
this.verifyDefinitionTextSpan(defs, startMarkerName);
646651

647652
definitions = defs.definitions;
648653
testName = "goToDefinitionsAndBoundSpan";
649654
}
650-
else {
651-
definitions = defs || [];
652-
testName = "goToDefinitions";
653-
}
654655

655656
if (endMarkers.length !== definitions.length) {
656657
this.raiseError(`${testName} failed - expected to find ${endMarkers.length} definitions but got ${definitions.length}`);
@@ -682,10 +683,6 @@ namespace FourSlash {
682683
}
683684
}
684685

685-
private isDefinitionInfoAndBoundSpan(definition: ts.DefinitionInfo[] | ts.DefinitionInfoAndBoundSpan | undefined): definition is ts.DefinitionInfoAndBoundSpan {
686-
return definition && (<ts.DefinitionInfoAndBoundSpan>definition).definitions !== undefined;
687-
}
688-
689686
public verifyGetEmitOutputForCurrentFile(expected: string): void {
690687
const emit = this.languageService.getEmitOutput(this.activeFile.fileName);
691688
if (emit.outputFiles.length !== 1) {

0 commit comments

Comments
 (0)