Updated shell

dynajoe · dynajoe · commit 0257d19843bc · 2013-08-11T21:49:57.000-05:00
diff --git a/_posts/2012-11-2-shell.md b/_posts/2012-11-2-shell.md
@@ -40,9 +40,9 @@ The output of your program might look something like this:
 
 {% highlight javascript %}
 foo
-<Buffer 64>
+<Buffer 61 73 64 0a>
 bar
-<Buffer 64>
+<Buffer 62 61 72 0a>
 {% endhighlight %}
 
 You can see that we're printing out a `Buffer` object. That's because the `input` variable passed in to our `function (input) { ... }` callback does not contain the string value of your input directly.
@@ -70,6 +70,8 @@ command [args...]
 We can use a handy regular expression to separate the arguments from the command: `/(\w+)(.*)/`. We'll then parse our arguments by splitting on white space.
 
 {% highlight javascript %}
+var stdin = process.openStdin();
+
 stdin.on('data', function (input) {
   var matches = input.toString().match(/(\w+)(.*)/);
   var command = matches[1].toLowerCase();
@@ -124,7 +126,7 @@ To clarify what's happening above, here's sample output of executing the regular
   input: 'cmd_name arg1 arg2'] // matches[4]
 {% endhighlight %}
 
-We are accessing ```matches[1]``` because it's the first group (groups are specified with the parenthesis). If you are unfamiliar with regular expressions, a good source to learn more is at [http://regular-expressions.info](http://www.regular-expressions.info/), in spite of (because of?) the awesome color scheme.
+We are accessing ```matches[1]``` because it's the first group (groups are specified with the parenthesis). If you are unfamiliar with regular expressions, a good source to learn more is at [http://regular-expressions.info](http://www.regular-expressions.info/).
 
 Now, jump back to your terminal and give our shell a try!
 
@@ -197,6 +199,26 @@ stdin.on('data', function (input) {
 });
 {% endhighlight %}
 
+#### As a side note about our commands object
+
+The commands object can get a bit hairy when we're nesting so many brackets deep. We can instead define our commands object like so:
+
+{% highlight javascript %}
+var commands = {};
+
+commands['pwd'] = function () {
+  console.log(process.cwd());
+};
+
+commands['ls'] = function (args) {
+  fs.readdir(args[0] || process.cwd(), function (err, entries) {
+    entries.forEach(function (e) {
+      console.log(e);
+    });
+  });
+};
+{% endhighlight %}
+
 ## Interacting with HTTP: Downloading a File
 
 Similarly to the `fs` module, Node.js also contains a core `http` module which can be used to act as a HTTP client or server. In the next lab you'll be creating a HTTP server, but for now, we'll focus on creating a simple `wget` command to download a file.
@@ -229,7 +251,7 @@ var commands = {
 };
 {% endhighlight %}
 
-Let's talk about what's happening in that callback. 
+Let's talk about what's happening in the callback provided to `http.get` callback. 
 
 First, we're creating a [writable stream](http://nodejs.org/api/stream.html#stream_class_stream_writable) to our file system using [fs.createWriteStream](http://nodejs.org/api/fs.html#fs_fs_createwritestream_path_options), named `file` (the second argument, or `'download'` by default). This will create or overwrite the file.
 
