Skip to content

Commit 1481876

Browse files
committed
fix travis and remove nullptr
1 parent a86fdad commit 1481876

2 files changed

Lines changed: 26 additions & 25 deletions

File tree

.travis.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,16 @@
11
sudo: false
22

3-
language: node_js
3+
language: cpp
44

55
env:
6-
- CXX=g++-4.8
6+
matrix:
7+
- TRAVIS_NODE_VERSION="0.8"
8+
- TRAVIS_NODE_VERSION="0.10"
9+
- TRAVIS_NODE_VERSION="0.12"
10+
- TRAVIS_NODE_VERSION="4"
11+
- TRAVIS_NODE_VERSION="3"
12+
- TRAVIS_NODE_VERSION="2"
13+
- TRAVIS_NODE_VERSION="1"
714

815
addons:
916
apt:
@@ -16,17 +23,11 @@ os:
1623
- linux
1724
- osx
1825

19-
node_js:
20-
- "0.12"
21-
- "0.10"
22-
- "0.8"
23-
- "4"
24-
- "3"
25-
- "2"
26-
- "1"
27-
2826
install:
29-
- npm install
30-
31-
script:
32-
- npm test
27+
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install $TRAVIS_NODE_VERSION
28+
- npm install npm
29+
- mv node_modules npm
30+
- npm/.bin/npm --version
31+
- if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
32+
- $CXX --version
33+
- npm/.bin/npm install

src/node_snap7_client.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1057,7 +1057,7 @@ void IOWorker::HandleOKCallback() {
10571057
static_cast<char*>(pData)
10581058
, int4 * s7client->GetByteCountFromWordLen(int5)
10591059
, S7Client::FreeCallback,
1060-
nullptr).ToLocalChecked();
1060+
NULL).ToLocalChecked();
10611061
} else {
10621062
argv2[1] = Nan::Null();
10631063
delete[] static_cast<char*>(pData);
@@ -1165,7 +1165,7 @@ void IOWorker::HandleOKCallback() {
11651165
static_cast<char*>(pData)
11661166
, int2
11671167
, S7Client::FreeCallback
1168-
, nullptr).ToLocalChecked();
1168+
, NULL).ToLocalChecked();
11691169
} else {
11701170
argv2[1] = Nan::Null();
11711171
delete[] static_cast<char*>(pData);
@@ -1180,7 +1180,7 @@ void IOWorker::HandleOKCallback() {
11801180
static_cast<char*>(pData)
11811181
, int3
11821182
, S7Client::FreeCallback
1183-
, nullptr).ToLocalChecked();
1183+
, NULL).ToLocalChecked();
11841184
} else {
11851185
argv2[1] = Nan::Null();
11861186
delete[] static_cast<char*>(pData);
@@ -1241,7 +1241,7 @@ void IOWorker::HandleOKCallback() {
12411241
reinterpret_cast<char*>(static_cast<PS7SZL>(pData))
12421242
, int3
12431243
, S7Client::FreeCallbackSZL
1244-
, nullptr).ToLocalChecked();
1244+
, NULL).ToLocalChecked();
12451245
} else {
12461246
argv2[1] = Nan::Null();
12471247
delete static_cast<PS7SZL>(pData);
@@ -1278,7 +1278,7 @@ NAN_METHOD(S7Client::ReadArea) {
12781278
bufferData
12791279
, size
12801280
, S7Client::FreeCallback
1281-
, nullptr).ToLocalChecked();
1281+
, NULL).ToLocalChecked();
12821282
info.GetReturnValue().Set(ret);
12831283
} else {
12841284
delete[] bufferData;
@@ -1438,7 +1438,7 @@ v8::Local<v8::Array> S7Client::S7DataItemToArray(
14381438
static_cast<char*>(Items[i].pdata)
14391439
, size
14401440
, S7Client::FreeCallback
1441-
, nullptr).ToLocalChecked());
1441+
, NULL).ToLocalChecked());
14421442
} else {
14431443
delete[] static_cast<char*>(Items[i].pdata);
14441444
Nan::Set(res_obj, Nan::New<v8::String>("Data").ToLocalChecked(), Nan::Null());
@@ -1742,7 +1742,7 @@ NAN_METHOD(S7Client::Upload) {
17421742
bufferData
17431743
, size
17441744
, S7Client::FreeCallback
1745-
, nullptr).ToLocalChecked();
1745+
, NULL).ToLocalChecked();
17461746
info.GetReturnValue().Set(ret_buf);
17471747
} else {
17481748
delete[] bufferData;
@@ -1775,7 +1775,7 @@ NAN_METHOD(S7Client::FullUpload) {
17751775
bufferData
17761776
, size
17771777
, S7Client::FreeCallback
1778-
, nullptr).ToLocalChecked();
1778+
, NULL).ToLocalChecked();
17791779
info.GetReturnValue().Set(ret_buf);
17801780
} else {
17811781
delete[] bufferData;
@@ -1846,7 +1846,7 @@ NAN_METHOD(S7Client::DBGet) {
18461846
bufferData
18471847
, size
18481848
, S7Client::FreeCallback
1849-
, nullptr).ToLocalChecked();
1849+
, NULL).ToLocalChecked();
18501850
info.GetReturnValue().Set(ret_buf);
18511851
} else {
18521852
delete[] bufferData;
@@ -2101,7 +2101,7 @@ NAN_METHOD(S7Client::ReadSZL) {
21012101
reinterpret_cast<char*>(SZL)
21022102
, size
21032103
, S7Client::FreeCallbackSZL
2104-
, nullptr).ToLocalChecked();
2104+
, NULL).ToLocalChecked();
21052105

21062106
info.GetReturnValue().Set(ret_buf);
21072107
} else {

0 commit comments

Comments
 (0)