Skip to content

Commit fd681e5

Browse files
committed
Removed U.isNullOrEmpty().
1 parent c9885c4 commit fd681e5

3 files changed

Lines changed: 2 additions & 20 deletions

File tree

changes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494
- removed: `Utils.isEmail()`
9595
- removed: `Utils.isURL()`
9696
- removed: `Utils.isValid()`
97+
- removed: `Utils.isNullOrEmpty()`
9798
- removed: `controller.global` property by Guy Fraser (a problem with referrencing)
9899
- removed: `controller.database()`, use `F.database()`
99100
- removed: `controller.functions()`

test/test-utils.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -392,12 +392,6 @@ function other() {
392392
str = '/logo/';
393393
assert.ok(utils.isStaticFile(str) === false, 'utils.isStaticFile(): ' + str);
394394

395-
str = null;
396-
assert.ok(utils.isNullOrEmpty(str) === true, 'utils.isNullOrEmpty(): null');
397-
398-
str = '';
399-
assert.ok(utils.isNullOrEmpty(str) === true, 'utils.isNullOrEmpty(): ' + str);
400-
401395
str = 'gif';
402396
assert.ok(utils.getContentType(str) === 'image/gif', 'utils.getContentType(): ' + str);
403397

utils.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1409,19 +1409,6 @@ exports.isStaticFile = function(url) {
14091409
return regexpSTATIC.test(url);
14101410
};
14111411

1412-
/**
1413-
* Checks if string is null or empty
1414-
* @param {String} str
1415-
* @return {Boolean}
1416-
*/
1417-
exports.isNullOrEmpty = function(str) {
1418-
1419-
if (typeof(str) !== 'string')
1420-
return true;
1421-
1422-
return str.length === 0;
1423-
};
1424-
14251412
/**
14261413
* Converts Value to number
14271414
* @param {Object} obj Value to convert.
@@ -5296,7 +5283,7 @@ exports.set = function(obj, path, value) {
52965283

52975284
for (var i = 0, length = arr.length; i < length; i++) {
52985285
p += (p !== '' ? '.' : '') + arr[i];
5299-
var type = exports.isArray(arr[i]) ? '[]' : '{}';
5286+
var type = arr[i] instanceof Array ? '[]' : '{}';
53005287

53015288
if (i !== length - 1) {
53025289
builder.push('if(typeof(w.' + p + ')!=="object"||w.' + p + '===null)w.' + p + '=' + type);

0 commit comments

Comments
 (0)