Skip to content

Commit f2867ed

Browse files
committed
Fixed email attachments.
1 parent 6d52d67 commit f2867ed

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

changes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
- updated: `GROUP()` by adding a new argument `url_prefix`
1818

19+
- fixed: mail attachments
1920
- fixed: mail `message.manually()`
2021

2122
======= 2.9.3 (HOTFIX)

mail.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Message.prototype.attachment = function(filename, name) {
263263
!name && (name = framework_utils.getName(filename));
264264
var extension = framework_utils.getExtension(name);
265265
!this.files && (this.files = []);
266-
this.files.push({ name: name, filename: filename, contentType: framework_utils.getContentType(extension), extension: extension });
266+
this.files.push({ name: name, filename: filename, type: framework_utils.getContentType(extension), extension: extension });
267267
return this;
268268
};
269269

@@ -291,7 +291,7 @@ Message.prototype.attachmentInline = function(filename, name, contentId) {
291291
!name && (name = framework_utils.getName(filename));
292292
!this.files && (this.files = []);
293293
var extension = framework_utils.getExtension(name);
294-
this.files.push({ name: name, filename: filename, contentType: framework_utils.getContentType(extension), disposition: 'inline', contentId: contentId, extension: extension });
294+
this.files.push({ name: name, filename: filename, type: framework_utils.getContentType(extension), disposition: 'inline', contentId: contentId, extension: extension });
295295
return this;
296296
};
297297

@@ -395,7 +395,7 @@ Mailer.prototype.$writeattachment = function(obj) {
395395
message.push('Content-Disposition: attachment; filename="' + name + '"');
396396
}
397397

398-
message.push('Content-Type: ' + extension + ';' + (isCalendar ? ' charset="utf-8"; method=REQUEST' : ''));
398+
message.push('Content-Type: ' + attachment.type + ';' + (isCalendar ? ' charset="utf-8"; method=REQUEST' : ''));
399399
message.push('Content-Transfer-Encoding: base64');
400400
message.push(CRLF);
401401
mailer.$writeline(obj, message.join(CRLF));

0 commit comments

Comments
 (0)