Skip to content

Commit a76def4

Browse files
committed
Fixed error events.
1 parent 016282f commit a76def4

2 files changed

Lines changed: 18 additions & 17 deletions

File tree

index.js

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ function Framework() {
407407

408408
this.id = null;
409409
this.version = 1940;
410-
this.version_header = '1.9.4-21';
410+
this.version_header = '1.9.4-22';
411411

412412
var version = process.version.toString().replace('v', '').replace(/\./g, '');
413413
if (version[0] !== '0' || version[1] !== '0')
@@ -9130,15 +9130,14 @@ Subscribe.prototype.end = function() {
91309130
* @param {Number} status Default HTTP status.
91319131
* @return {FrameworkSubscribe}
91329132
*/
9133-
Subscribe.prototype.execute = function(status) {
9133+
Subscribe.prototype.execute = function(status, isError) {
91349134

91359135
var self = this;
91369136
var route = self.route;
91379137
var req = self.req;
91389138
var res = self.res;
91399139

9140-
// if ((route === null || route.controller[0] === '#') && status > 399) {
9141-
if (!route && status > 399) {
9140+
if (isError || !route) {
91429141
switch (status) {
91439142
case 400:
91449143
framework.stats.response.error400++;
@@ -9165,11 +9164,13 @@ Subscribe.prototype.execute = function(status) {
91659164
framework.stats.response.error501++;
91669165
break;
91679166
}
9167+
91689168
if (status !== 500)
91699169
framework.emit('error' + status, req, res, self.exception);
91709170
}
91719171

91729172
if (route === null) {
9173+
91739174
if (!status)
91749175
status = 404;
91759176

@@ -9308,7 +9309,7 @@ Subscribe.prototype.doExecute = function() {
93089309
framework.error(err, name, req.uri);
93099310
self.exception = err;
93109311
self.route = framework.lookup(req, '#500');
9311-
self.execute(500);
9312+
self.execute(500, true);
93129313
}
93139314

93149315
return self;
@@ -9330,7 +9331,7 @@ Subscribe.prototype.doAuthorization = function(isLogged, user) {
93309331
req.user = user;
93319332

93329333
if (self.route && !self.route.isMEMBER && isLogged) {
9333-
self.execute(req.buffer_exceeded ? 431 : 401);
9334+
self.execute(req.buffer_exceeded ? 431 : 401, true);
93349335
return;
93359336
}
93369337

@@ -9362,7 +9363,7 @@ Subscribe.prototype.doEnd = function() {
93629363
}
93639364

93649365
self.route = route;
9365-
self.execute(431);
9366+
self.execute(431, true);
93669367
return self;
93679368
}
93689369

@@ -9453,15 +9454,15 @@ Subscribe.prototype.route400 = function(problem) {
94539454
var self = this;
94549455
self.route = framework.lookup(self.req, '#400');
94559456
self.exception = problem;
9456-
self.execute(400);
9457+
self.execute(400, true);
94579458
return self;
94589459
};
94599460

94609461
Subscribe.prototype.route500 = function(problem) {
94619462
var self = this;
94629463
self.route = framework.lookup(self.req, '#500');
94639464
self.exception = problem;
9464-
self.execute(500);
9465+
self.execute(500, true);
94659466
return self;
94669467
};
94679468

@@ -9579,7 +9580,7 @@ Subscribe.prototype.doCancel = function() {
95799580
self.controller.isTimeout = true;
95809581
self.controller.isCanceled = true;
95819582
self.route = framework.lookup(self.req, '#408');
9582-
self.execute(408);
9583+
self.execute(408, true);
95839584
};
95849585

95859586
// *********************************************************************************
@@ -12162,7 +12163,7 @@ Controller.prototype.view400 = function(problem) {
1216212163
self.subscribe.success();
1216312164
self.subscribe.route = framework.lookup(self.req, '#400');
1216412165
self.subscribe.exception = problem;
12165-
self.subscribe.execute(400);
12166+
self.subscribe.execute(400, true);
1216612167
return self;
1216712168
};
1216812169

@@ -12192,7 +12193,7 @@ Controller.prototype.view401 = function(problem) {
1219212193
self.subscribe.success();
1219312194
self.subscribe.route = framework.lookup(self.req, '#401');
1219412195
self.subscribe.exception = problem;
12195-
self.subscribe.execute(401);
12196+
self.subscribe.execute(401, true);
1219612197
return self;
1219712198
};
1219812199

@@ -12222,7 +12223,7 @@ Controller.prototype.view403 = function(problem) {
1222212223
self.subscribe.success();
1222312224
self.subscribe.route = framework.lookup(self.req, '#403');
1222412225
self.subscribe.exception = problem;
12225-
self.subscribe.execute(403);
12226+
self.subscribe.execute(403, true);
1222612227
return self;
1222712228
};
1222812229

@@ -12251,7 +12252,7 @@ Controller.prototype.view404 = function(problem) {
1225112252
self.subscribe.success();
1225212253
self.subscribe.route = framework.lookup(self.req, '#404');
1225312254
self.subscribe.exception = problem;
12254-
self.subscribe.execute(404);
12255+
self.subscribe.execute(404, true);
1225512256
return self;
1225612257
};
1225712258

@@ -12273,7 +12274,7 @@ Controller.prototype.view500 = function(error) {
1227312274
self.subscribe.success();
1227412275
self.subscribe.route = framework.lookup(self.req, '#500');
1227512276
self.subscribe.exception = error;
12276-
self.subscribe.execute(500);
12277+
self.subscribe.execute(500, true);
1227712278
return self;
1227812279
};
1227912280

@@ -12304,7 +12305,7 @@ Controller.prototype.view501 = function(problem) {
1230412305
self.subscribe.success();
1230512306
self.subscribe.route = framework.lookup(self.req, '#501');
1230612307
self.subscribe.exception = problem;
12307-
self.subscribe.execute(501);
12308+
self.subscribe.execute(501, true);
1230812309
return self;
1230912310
};
1231012311

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"name": "Radek / rsmogura",
5151
"email": ""
5252
}],
53-
"version": "1.9.4-21",
53+
"version": "1.9.4-22",
5454
"homepage": "http://www.totaljs.com",
5555
"bugs": {
5656
"url": "https://github.com/totaljs/framework/issues",

0 commit comments

Comments
 (0)