Skip to content

Commit 2bc51ec

Browse files
committed
Fixed TLS.
1 parent a6479d6 commit 2bc51ec

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

mail.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ Mailer.prototype.switchToTLS = function(obj, options) {
333333
// obj.socket.removeAllListeners('clientError');
334334
// obj.socket.removeAllListeners('line');
335335

336-
var opt = framework_utils.copy(options.tls, { socket: socket, host: socket.$host, ciphers: 'SSLv3' });
336+
var opt = framework_utils.copy(options.tls, { socket: obj.socket, host: obj.socket.$host, ciphers: 'SSLv3' });
337337
obj.socket2 = tls.connect(opt, () => self._send(obj, options, true));
338338

339339
obj.socket2.on('error', function(err) {
@@ -688,7 +688,6 @@ Mailer.prototype._send = function(obj, options, autosend) {
688688
var command = '';
689689
var auth = [];
690690
var ending = null;
691-
var isTLS = false;
692691
var response = '';
693692
var socket = obj.socket2 ? obj.socket2 : obj.socket;
694693
var host = obj.host;
@@ -786,12 +785,12 @@ Mailer.prototype._send = function(obj, options, autosend) {
786785
switch (code) {
787786
case 220:
788787

789-
if (isTLS) {
788+
if (obj.isTLS) {
790789
mailer.switchToTLS(obj, options);
791790
return;
792791
}
793792

794-
command = isTLS || (options.user && options.password) || REG_ESMTP.test(line) ? 'EHLO' : 'HELO';
793+
command = obj.isTLS || (options.user && options.password) || REG_ESMTP.test(line) ? 'EHLO' : 'HELO';
795794
mailer._writeline(obj, command + ' ' + host);
796795
break;
797796

@@ -834,9 +833,9 @@ Mailer.prototype._send = function(obj, options, autosend) {
834833

835834
case 334: // LOGIN
836835

837-
if (!self.tls && !isTLS && options.tls) {
838-
isTLS = true;
839-
mail._writeline(obj, 'STARTTLS');
836+
if (!self.tls && !obj.isTLS && options.tls) {
837+
obj.isTLS = true;
838+
mailer._writeline(obj, 'STARTTLS');
840839
return;
841840
}
842841

0 commit comments

Comments
 (0)