Put C++11 capable version back, change name to readme style

jkeiser · jkeiser · commit f632e7c0435e · 2020-06-18T12:50:49.000-07:00
diff --git a/doc/basics.md b/doc/basics.md
@@ -405,7 +405,7 @@ The next two functions will take as input a JSON document containing an array wi
 ```C++
 simdjson::dom::parser parser{};
 
-bool ParseDouble(const char *j, double &d) {
+bool parse_double(const char *j, double &d) {
   simdjson::error_code error;
   parser.parse(j, std::strlen(j))
         .at(0)
@@ -415,10 +415,13 @@ bool ParseDouble(const char *j, double &d) {
   return true;
 }
 
-bool ParseString(const char *j, std::string &s) {
-  auto [answer, error] = parser.parse(j,strlen(j))
+bool parse_string(const char *j, std::string &s) {
+  simdjson::error_code error;
+  std::string_view answer;
+  parser.parse(j,strlen(j))
         .at(0)
-        .get<std::string_view>();
+        .get<std::string_view>()
+        .tie(answer, error);
   if (error) { return false; }
   s.assign(answer.data(), answer.size());
   return true;
diff --git a/tests/readme_examples_noexceptions.cpp b/tests/readme_examples_noexceptions.cpp
@@ -199,16 +199,6 @@ bool ParseDouble(const char *j, double &d) {
 }
 
 // See https://github.com/miloyip/nativejson-benchmark/blob/master/src/tests/simdjsontest.cpp
-#ifdef SIMDJSON_CPLUSPLUS17
-bool ParseString(const char *j, std::string &s) {
-  auto [answer, error] = parser.parse(j,strlen(j))
-        .at(0)
-        .get<std::string_view>();
-  if (error) { return false; }
-  s.assign(answer.data(), answer.size());
-  return true;
-}
-#else
 bool ParseString(const char *j, std::string &s) {
   simdjson::error_code error;
   std::string_view answer;
@@ -220,7 +210,6 @@ bool ParseString(const char *j, std::string &s) {
   s.assign(answer.data(), answer.size());
   return true;
 }
-#endif
 
 
 int main() {
