Remove SUCCESS_AND_HAS_MORE (internal only value)

jkeiser · jkeiser · commit d43a4e9df98a · 2020-06-07T16:20:55.000-07:00
diff --git a/include/simdjson/error.h b/include/simdjson/error.h
@@ -11,7 +11,6 @@ namespace simdjson {
  */
 enum error_code {
   SUCCESS = 0,              ///< No error
-  SUCCESS_AND_HAS_MORE,     ///< @private No error and buffer still has more data
   CAPACITY,                 ///< This parser can't support a document that big
   MEMALLOC,                 ///< Error allocating memory, most likely out of memory
   TAPE_ERROR,               ///< Something went wrong while writing to the tape (stage 2), this is a generic error
diff --git a/include/simdjson/internal/dom_parser_implementation.h b/include/simdjson/internal/dom_parser_implementation.h
@@ -76,8 +76,7 @@ class dom_parser_implementation {
    * Overridden by each implementation.
    *
    * @param doc The document to output to.
-   * @param next_json The next structural index. Start this at 0 the first time, and it will be updated to the next value to pass each time.
-   * @return The error code, SUCCESS if there was no error, or SUCCESS_AND_HAS_MORE if there was no error and stage2 can be called again.
+   * @return The error code, SUCCESS if there was no error, or EMPTY if all documents have been parsed.
    */
   WARN_UNUSED virtual error_code stage2_next(dom::document &doc) noexcept = 0;
 
diff --git a/src/error.cpp b/src/error.cpp
@@ -5,7 +5,6 @@ namespace internal {
 
   SIMDJSON_DLLIMPORTEXPORT const error_code_info error_codes[] {
     { SUCCESS, "No error" },
-    { SUCCESS_AND_HAS_MORE, "No error and buffer still has more data" },
     { CAPACITY, "This parser can't support a document that big" },
     { MEMALLOC, "Error allocating memory, we're most likely out of memory" },
     { TAPE_ERROR, "The JSON document has an improper structure: missing or superfluous commas, braces, missing keys, etc." },

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ class dom_parser_implementation {`
`76`	`76`	`* Overridden by each implementation.`
`77`	`77`	`*`
`78`	`78`	`* @param doc The document to output to.`
`79`		`- * @param next_json The next structural index. Start this at 0 the first time, and it will be updated to the next value to pass each time.`
`80`		`- * @return The error code, SUCCESS if there was no error, or SUCCESS_AND_HAS_MORE if there was no error and stage2 can be called again.`
	`79`	`+ * @return The error code, SUCCESS if there was no error, or EMPTY if all documents have been parsed.`
`81`	`80`	`*/`
`82`	`81`	`WARN_UNUSED virtual error_code stage2_next(dom::document &doc) noexcept = 0;`
`83`	`82`