This code is terrible and should not be there. (simdjson#496)

lemire · web-flow · commit 083569fca8fa · 2020-02-13T07:38:11.000-05:00
diff --git a/include/simdjson/padded_string.h b/include/simdjson/padded_string.h
@@ -21,8 +21,6 @@ inline char *allocate_padded_buffer(size_t length) noexcept {
   char *padded_buffer = aligned_malloc_char(64, totalpaddedlength);
 #ifndef NDEBUG
   if (padded_buffer == nullptr) {
-    errno = EINVAL;
-    perror("simdjson::allocate_padded_buffer() aligned_malloc_char() failed");
     return nullptr;
   }
 #endif // NDEBUG

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@ inline char *allocate_padded_buffer(size_t length) noexcept {`
`21`	`21`	`char *padded_buffer = aligned_malloc_char(64, totalpaddedlength);`
`22`	`22`	`#ifndef NDEBUG`
`23`	`23`	`if (padded_buffer == nullptr) {`
`24`		`- errno = EINVAL;`
`25`		`- perror("simdjson::allocate_padded_buffer() aligned_malloc_char() failed");`
`26`	`24`	`return nullptr;`
`27`	`25`	`}`
`28`	`26`	`#endif // NDEBUG`